diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2004-10-15 22:40:29 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2004-10-15 22:40:29 +0000 |
| commit | 9ffc8ed58b55cb3925bb95cc184583fcb9772013 (patch) | |
| tree | 9039f51525070c611a86f03a2e85a13b24005ac3 /src/backend/access/index | |
| parent | db9e2fd0a9144707055ed382f184f5a9c11aafff (diff) | |
| download | postgresql-9ffc8ed58b55cb3925bb95cc184583fcb9772013.tar.gz postgresql-9ffc8ed58b55cb3925bb95cc184583fcb9772013.zip | |
Repair possible failure to update hint bits back to disk, per
http://archives.postgresql.org/pgsql-hackers/2004-10/msg00464.php.
This fix is intended to be permanent: it moves the responsibility for
calling SetBufferCommitInfoNeedsSave() into the tqual.c routines,
eliminating the requirement for callers to test whether t_infomask changed.
Also, tighten validity checking on buffer IDs in bufmgr.c --- several
routines were paranoid about out-of-range shared buffer numbers but not
about out-of-range local ones, which seems a tad pointless.
Diffstat (limited to 'src/backend/access/index')
| -rw-r--r-- | src/backend/access/index/indexam.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/src/backend/access/index/indexam.c b/src/backend/access/index/indexam.c index 7c698fb48a2..214f646276b 100644 --- a/src/backend/access/index/indexam.c +++ b/src/backend/access/index/indexam.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/access/index/indexam.c,v 1.75 2004/09/30 23:21:14 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/access/index/indexam.c,v 1.76 2004/10/15 22:39:46 tgl Exp $ * * INTERFACE ROUTINES * index_open - open an index relation by relation OID @@ -497,7 +497,6 @@ index_getnext(IndexScanDesc scan, ScanDirection direction) for (;;) { bool found; - uint16 sv_infomask; pgstat_count_index_scan(&scan->xs_pgstat_info); @@ -541,19 +540,14 @@ index_getnext(IndexScanDesc scan, ScanDirection direction) * index AM to not return it on future indexscans. * * We told heap_release_fetch to keep a pin on the buffer, so we can - * re-access the tuple here. But we must re-lock the buffer - * first. Also, it's just barely possible for an update of hint - * bits to occur here. + * re-access the tuple here. But we must re-lock the buffer first. */ LockBuffer(scan->xs_cbuf, BUFFER_LOCK_SHARE); - sv_infomask = heapTuple->t_data->t_infomask; - if (HeapTupleSatisfiesVacuum(heapTuple->t_data, RecentGlobalXmin) == - HEAPTUPLE_DEAD) + if (HeapTupleSatisfiesVacuum(heapTuple->t_data, RecentGlobalXmin, + scan->xs_cbuf) == HEAPTUPLE_DEAD) scan->kill_prior_tuple = true; - if (sv_infomask != heapTuple->t_data->t_infomask) - SetBufferCommitInfoNeedsSave(scan->xs_cbuf); LockBuffer(scan->xs_cbuf, BUFFER_LOCK_UNLOCK); } |