diff options
| author | Noah Misch <noah@leadboat.com> | 2024-10-25 06:51:02 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2024-10-25 06:51:02 -0700 |
| commit | 243e9b40f1b2dd09d6e5bf91ebf6e822a2cd3704 (patch) | |
| tree | d092b3c3b261da64a5f17a35b87d67626f9591f7 /src/backend/access/rmgrdesc | |
| parent | 0fe173680e148984a150326b80c322a91ffa899d (diff) | |
| download | postgresql-243e9b40f1b2dd09d6e5bf91ebf6e822a2cd3704.tar.gz postgresql-243e9b40f1b2dd09d6e5bf91ebf6e822a2cd3704.zip | |
For inplace update, send nontransactional invalidations.
The inplace update survives ROLLBACK. The inval didn't, so another
backend's DDL could then update the row without incorporating the
inplace update. In the test this fixes, a mix of CREATE INDEX and ALTER
TABLE resulted in a table with an index, yet relhasindex=f. That is a
source of index corruption. Back-patch to v12 (all supported versions).
The back branch versions don't change WAL, because those branches just
added end-of-recovery SIResetAll(). All branches change the ABI of
extern function PrepareToInvalidateCacheTuple(). No PGXN extension
calls that, and there's no apparent use case in extensions.
Reviewed by Nitin Motiani and (in earlier versions) Andres Freund.
Discussion: https://postgr.es/m/20240523000548.58.nmisch@google.com
Diffstat (limited to 'src/backend/access/rmgrdesc')
| -rw-r--r-- | src/backend/access/rmgrdesc/heapdesc.c | 4 | ||||
| -rw-r--r-- | src/backend/access/rmgrdesc/standbydesc.c | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/backend/access/rmgrdesc/heapdesc.c b/src/backend/access/rmgrdesc/heapdesc.c index 5f5673e088b..f31cc3a4df4 100644 --- a/src/backend/access/rmgrdesc/heapdesc.c +++ b/src/backend/access/rmgrdesc/heapdesc.c @@ -16,6 +16,7 @@ #include "access/heapam_xlog.h" #include "access/rmgrdesc_utils.h" +#include "storage/standbydefs.h" /* * NOTE: "keyname" argument cannot have trailing spaces or punctuation @@ -253,6 +254,9 @@ heap_desc(StringInfo buf, XLogReaderState *record) xl_heap_inplace *xlrec = (xl_heap_inplace *) rec; appendStringInfo(buf, "off: %u", xlrec->offnum); + standby_desc_invalidations(buf, xlrec->nmsgs, xlrec->msgs, + xlrec->dbId, xlrec->tsId, + xlrec->relcacheInitFileInval); } } diff --git a/src/backend/access/rmgrdesc/standbydesc.c b/src/backend/access/rmgrdesc/standbydesc.c index 25f870b187e..32e509a4006 100644 --- a/src/backend/access/rmgrdesc/standbydesc.c +++ b/src/backend/access/rmgrdesc/standbydesc.c @@ -96,11 +96,7 @@ standby_identify(uint8 info) return id; } -/* - * This routine is used by both standby_desc and xact_desc, because - * transaction commits and XLOG_INVALIDATIONS messages contain invalidations; - * it seems pointless to duplicate the code. - */ +/* also used by non-standby records having analogous invalidation fields */ void standby_desc_invalidations(StringInfo buf, int nmsgs, SharedInvalidationMessage *msgs, |