diff options
| author | Jeff Davis <jdavis@postgresql.org> | 2022-11-10 14:46:30 -0800 |
|---|---|---|
| committer | Jeff Davis <jdavis@postgresql.org> | 2022-11-11 12:46:44 -0800 |
| commit | 7dd39e9e80288f2f4ef2990c4f074010973b56cb (patch) | |
| tree | b4004edfb1ec56aac196adc3dceefc732540e73b /src/backend/access/spgist/spginsert.c | |
| parent | 6a1396fd19a3cefc71e176931c9e02a3b12d32eb (diff) | |
| download | postgresql-7dd39e9e80288f2f4ef2990c4f074010973b56cb.tar.gz postgresql-7dd39e9e80288f2f4ef2990c4f074010973b56cb.zip | |
Fix theoretical torn page hazard.
The original report was concerned with a possible inconsistency
between the heap and the visibility map, which I was unable to
confirm. The concern has been retracted.
However, there did seem to be a torn page hazard when using
checksums. By not setting the heap page LSN during redo, the
protections of minRecoveryPoint were bypassed. Fixed, along with a
misleading comment.
It may have been impossible to hit this problem in practice, because
it would require a page tear between the checksum and the flags, so I
am marking this as a theoretical risk. But, as discussed, it did
violate expectations about the page LSN, so it may have other
consequences.
Backpatch to all supported versions.
Reported-by: Konstantin Knizhnik
Reviewed-by: Konstantin Knizhnik
Discussion: https://postgr.es/m/fed17dac-8cb8-4f5b-d462-1bb4908c029e@garret.ru
Backpatch-through: 11
Diffstat (limited to 'src/backend/access/spgist/spginsert.c')
0 files changed, 0 insertions, 0 deletions