diff options
| author | Andres Freund <andres@anarazel.de> | 2019-11-08 00:44:52 -0800 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2019-11-08 11:49:29 -0800 |
| commit | aae50236e4ce95c05a3962be0814c74c5a22206d (patch) | |
| tree | ab040612da65567def53a6ee17db9b0b54f3037d /src/backend/access/spgist/spginsert.c | |
| parent | 71a8a4f6e36547bb060dbcc961ea9b57420f7190 (diff) | |
| download | postgresql-aae50236e4ce95c05a3962be0814c74c5a22206d.tar.gz postgresql-aae50236e4ce95c05a3962be0814c74c5a22206d.zip | |
Pass ItemPointer not HeapTuple to IndexBuildCallback.
Not all AMs use HeapTuples internally, making it inconvenient to pass
a HeapTuple. As the index callbacks really only need the TID, not the
full tuple, modify callback to only take ItemPointer.
Author: Ashwin Agrawal
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/CALfoeis6=8ehuR=VNtHvj3z16cYfCwPdTcpaxU+sfSUJ5QgR3g@mail.gmail.com
Diffstat (limited to 'src/backend/access/spgist/spginsert.c')
| -rw-r--r-- | src/backend/access/spgist/spginsert.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/access/spgist/spginsert.c b/src/backend/access/spgist/spginsert.c index b40bd440cf0..dd9088741cf 100644 --- a/src/backend/access/spgist/spginsert.c +++ b/src/backend/access/spgist/spginsert.c @@ -40,7 +40,7 @@ typedef struct /* Callback to process one heap tuple during table_index_build_scan */ static void -spgistBuildCallback(Relation index, HeapTuple htup, Datum *values, +spgistBuildCallback(Relation index, ItemPointer tid, Datum *values, bool *isnull, bool tupleIsAlive, void *state) { SpGistBuildState *buildstate = (SpGistBuildState *) state; @@ -55,7 +55,7 @@ spgistBuildCallback(Relation index, HeapTuple htup, Datum *values, * lock on some buffer. So we need to be willing to retry. We can flush * any temp data when retrying. */ - while (!spgdoinsert(index, &buildstate->spgstate, &htup->t_self, + while (!spgdoinsert(index, &buildstate->spgstate, tid, *values, *isnull)) { MemoryContextReset(buildstate->tmpCtx); |