diff options
| author | Alexander Korotkov <akorotkov@postgresql.org> | 2019-09-08 21:13:40 +0300 |
|---|---|---|
| committer | Alexander Korotkov <akorotkov@postgresql.org> | 2019-09-08 22:08:12 +0300 |
| commit | 02f90879e75b3d4ccdba1ec7c3cad6af08dff77d (patch) | |
| tree | 9fc6dd6fdc3aba51027f5e02db15a0a271471882 /src/backend/access/spgist/spgscan.c | |
| parent | e5d8f3596100da0d38a38513c69e803b7fe7041a (diff) | |
| download | postgresql-02f90879e75b3d4ccdba1ec7c3cad6af08dff77d.tar.gz postgresql-02f90879e75b3d4ccdba1ec7c3cad6af08dff77d.zip | |
Fix handling of NULL distances in KNN-GiST
In order to implement NULL LAST semantic GiST previously assumed distance to
the NULL value to be Inf. However, our distance functions can return Inf and
NaN for non-null values. In such cases, NULL LAST semantic appears to be
broken. This commit fixes that by introducing separate array of null flags for
distances.
Backpatch to all supported versions.
Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com
Author: Alexander Korotkov
Backpatch-through: 9.4
Diffstat (limited to 'src/backend/access/spgist/spgscan.c')
| -rw-r--r-- | src/backend/access/spgist/spgscan.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/backend/access/spgist/spgscan.c b/src/backend/access/spgist/spgscan.c index 1cf28ecf2fd..2bd4037af9e 100644 --- a/src/backend/access/spgist/spgscan.c +++ b/src/backend/access/spgist/spgscan.c @@ -929,6 +929,7 @@ spggettuple(IndexScanDesc scan, ScanDirection dir) if (so->numberOfOrderBys > 0) index_store_float8_orderby_distances(scan, so->orderByTypes, so->distances[so->iPtr], + NULL, so->recheckDistances[so->iPtr]); so->iPtr++; return true; |