diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2012-08-02 15:34:14 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2012-08-02 15:34:14 -0400 |
| commit | 962e0cc71e839c58fb9125fa85511b8bbb8bdbee (patch) | |
| tree | e91d54f941d8207c0a48b642fd59fe9fcd46072e /src/backend/access/spgist/spgutils.c | |
| parent | 7719ed04bc4b8f08dab85ffe9c79a52fdb4756dd (diff) | |
| download | postgresql-962e0cc71e839c58fb9125fa85511b8bbb8bdbee.tar.gz postgresql-962e0cc71e839c58fb9125fa85511b8bbb8bdbee.zip | |
Fix race conditions associated with SPGiST redirection tuples.
The correct test for whether a redirection tuple is removable is whether
tuple's xid < RecentGlobalXmin, not OldestXmin; the previous coding
failed to protect index searches being done in concurrent transactions that
have no XID. This mirrors the recent fix in btree's page recycling logic
made in commit d3abbbebe52eb1e59e621c880ad57df9d40d13f2.
Also, WAL-log the newest XID of any removed redirection tuple on an index
page, and apply ResolveRecoveryConflictWithSnapshot during InHotStandby WAL
replay. This protects against concurrent Hot Standby transactions possibly
needing to see the redirection tuple(s).
Per my query of 2012-03-12 and subsequent discussion.
Diffstat (limited to 'src/backend/access/spgist/spgutils.c')
| -rw-r--r-- | src/backend/access/spgist/spgutils.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/backend/access/spgist/spgutils.c b/src/backend/access/spgist/spgutils.c index afa14841003..72aae02b450 100644 --- a/src/backend/access/spgist/spgutils.c +++ b/src/backend/access/spgist/spgutils.c @@ -722,6 +722,7 @@ spgFormDeadTuple(SpGistState *state, int tupstate, if (tupstate == SPGIST_REDIRECT) { ItemPointerSet(&tuple->pointer, blkno, offnum); + Assert(TransactionIdIsValid(state->myXid)); tuple->xid = state->myXid; } else |