diff options
| author | Amit Kapila <akapila@postgresql.org> | 2020-05-05 08:00:53 +0530 |
|---|---|---|
| committer | Amit Kapila <akapila@postgresql.org> | 2020-05-05 08:00:53 +0530 |
| commit | 69bfaf2e1de49de76d7dec1c45511932a5ef502b (patch) | |
| tree | e9ff414948222324edbb33f0f603ee4800e218bd /src/backend/access/transam/xloginsert.c | |
| parent | 5545b69ae65f27ba1f4ceaf24486e98c186e9412 (diff) | |
| download | postgresql-69bfaf2e1de49de76d7dec1c45511932a5ef502b.tar.gz postgresql-69bfaf2e1de49de76d7dec1c45511932a5ef502b.zip | |
Change the display of WAL usage statistics in Explain.
In commit 33e05f89c5, we have added the option to display WAL usage
statistics in Explain and auto_explain. The display format used two spaces
between each field which is inconsistent with Buffer usage statistics which
is using one space between each field. Change the format to make WAL usage
statistics consistent with Buffer usage statistics.
This commit also changed the usage of "full page writes" to
"full page images" for WAL usage statistics to make it consistent with
other parts of code and docs.
Author: Julien Rouhaud, Amit Kapila
Reviewed-by: Justin Pryzby, Kyotaro Horiguchi and Amit Kapila
Discussion: https://postgr.es/m/CAB-hujrP8ZfUkvL5OYETipQwA=e3n7oqHFU=4ZLxWS_Cza3kQQ@mail.gmail.com
Diffstat (limited to 'src/backend/access/transam/xloginsert.c')
| -rw-r--r-- | src/backend/access/transam/xloginsert.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c index 4259309dbae..b21679f09eb 100644 --- a/src/backend/access/transam/xloginsert.c +++ b/src/backend/access/transam/xloginsert.c @@ -109,7 +109,7 @@ static MemoryContext xloginsert_cxt; static XLogRecData *XLogRecordAssemble(RmgrId rmid, uint8 info, XLogRecPtr RedoRecPtr, bool doPageWrites, - XLogRecPtr *fpw_lsn, int *num_fpw); + XLogRecPtr *fpw_lsn, int *num_fpi); static bool XLogCompressBackupBlock(char *page, uint16 hole_offset, uint16 hole_length, char *dest, uint16 *dlen); @@ -449,7 +449,7 @@ XLogInsert(RmgrId rmid, uint8 info) bool doPageWrites; XLogRecPtr fpw_lsn; XLogRecData *rdt; - int num_fpw = 0; + int num_fpi = 0; /* * Get values needed to decide whether to do full-page writes. Since @@ -459,9 +459,9 @@ XLogInsert(RmgrId rmid, uint8 info) GetFullPageWriteInfo(&RedoRecPtr, &doPageWrites); rdt = XLogRecordAssemble(rmid, info, RedoRecPtr, doPageWrites, - &fpw_lsn, &num_fpw); + &fpw_lsn, &num_fpi); - EndPos = XLogInsertRecord(rdt, fpw_lsn, curinsert_flags, num_fpw); + EndPos = XLogInsertRecord(rdt, fpw_lsn, curinsert_flags, num_fpi); } while (EndPos == InvalidXLogRecPtr); XLogResetInsertion(); @@ -484,7 +484,7 @@ XLogInsert(RmgrId rmid, uint8 info) static XLogRecData * XLogRecordAssemble(RmgrId rmid, uint8 info, XLogRecPtr RedoRecPtr, bool doPageWrites, - XLogRecPtr *fpw_lsn, int *num_fpw) + XLogRecPtr *fpw_lsn, int *num_fpi) { XLogRecData *rdt; uint32 total_len = 0; @@ -638,7 +638,7 @@ XLogRecordAssemble(RmgrId rmid, uint8 info, bkpb.fork_flags |= BKPBLOCK_HAS_IMAGE; /* Report a full page image constructed for the WAL record */ - *num_fpw += 1; + *num_fpi += 1; /* * Construct XLogRecData entries for the page content. |