diff options
| author | Andres Freund <andres@anarazel.de> | 2020-04-07 17:36:23 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2020-04-07 17:36:23 -0700 |
| commit | 75848bc74411130ede23995d0ab1aefb12c4c4b0 (patch) | |
| tree | 239b59be148611c1d03f0cc97f599af42a59a400 /src/backend/access/transam/xloginsert.c | |
| parent | 2b88fdde30d8e9bf833b75a014189e9148233b85 (diff) | |
| download | postgresql-75848bc74411130ede23995d0ab1aefb12c4c4b0.tar.gz postgresql-75848bc74411130ede23995d0ab1aefb12c4c4b0.zip | |
snapshot scalability: Move delayChkpt from PGXACT to PGPROC.
The goal of separating hotly accessed per-backend data from PGPROC
into PGXACT is to make accesses fast (GetSnapshotData() in
particular). But delayChkpt is not actually accessed frequently; only
when starting a checkpoint. As it is frequently modified (multiple
times in the course of a single transaction), storing it in the same
cacheline as hotly accessed data unnecessarily dirties a contended
cacheline.
Therefore move delayChkpt to PGPROC.
This is part of a larger series of patches intending to improve
GetSnapshotData() scalability. It is committed and pushed separately,
as it is independently beneficial (small but measurable win, limited
by the other frequent modifications of PGXACT).
Author: Andres Freund
Reviewed-By: Robert Haas, Thomas Munro, David Rowley
Discussion: https://postgr.es/m/20200301083601.ews6hz5dduc3w2se@alap3.anarazel.de
Diffstat (limited to 'src/backend/access/transam/xloginsert.c')
| -rw-r--r-- | src/backend/access/transam/xloginsert.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c index 5e032e7042d..4259309dbae 100644 --- a/src/backend/access/transam/xloginsert.c +++ b/src/backend/access/transam/xloginsert.c @@ -904,7 +904,7 @@ XLogSaveBufferForHint(Buffer buffer, bool buffer_std) /* * Ensure no checkpoint can change our view of RedoRecPtr. */ - Assert(MyPgXact->delayChkpt); + Assert(MyProc->delayChkpt); /* * Update RedoRecPtr so that we can make the right decision |