diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2016-04-04 11:13:17 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2016-04-04 11:13:17 -0400 |
commit | 58666ed28ab59a2686ee08bc648b4e9959aacfce (patch) | |
tree | 2ed4b9b6f70540c74b07cfb515ce538d17f68eee /src/backend/access/transam/xlogutils.c | |
parent | eb7308d29875df773b5b52b06ed3d8b60f1b8242 (diff) | |
download | postgresql-58666ed28ab59a2686ee08bc648b4e9959aacfce.tar.gz postgresql-58666ed28ab59a2686ee08bc648b4e9959aacfce.zip |
Fix latent portability issue in pgwin32_dispatch_queued_signals().
The first iteration of the signal-checking loop would compute sigmask(0)
which expands to 1<<(-1) which is undefined behavior according to the
C standard. The lack of field reports of trouble suggest that it
evaluates to 0 on all existing Windows compilers, but that's hardly
something to rely on. Since signal 0 isn't a queueable signal anyway,
we can just make the loop iterate from 1 instead, and save a few cycles
as well as avoiding the undefined behavior.
In passing, avoid evaluating the volatile expression UNBLOCKED_SIGNAL_QUEUE
twice in a row; there's no reason to waste cycles like that.
Noted by Aleksander Alekseev, though this isn't his proposed fix.
Back-patch to all supported branches.
Diffstat (limited to 'src/backend/access/transam/xlogutils.c')
0 files changed, 0 insertions, 0 deletions