diff options
| author | Andres Freund <andres@anarazel.de> | 2023-04-05 13:55:15 -0700 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2023-04-05 14:17:55 -0700 |
| commit | 12f3867f5534754c8bac5af35228d4079edc3a00 (patch) | |
| tree | 5d3aff4538d103f7d83d8dfca27b1a0f4791ada4 /src/backend/access | |
| parent | 16dc2703c5413534d4989e08253e8f4fcb0e2aab (diff) | |
| download | postgresql-12f3867f5534754c8bac5af35228d4079edc3a00.tar.gz postgresql-12f3867f5534754c8bac5af35228d4079edc3a00.zip | |
bufmgr: Support multiple in-progress IOs by using resowner
A future patch will add support for extending relations by multiple blocks at
once. To be concurrency safe, the buffers for those blocks need to be marked
as BM_IO_IN_PROGRESS. Until now we only had infrastructure for recovering from
an IO error for a single buffer. This commit extends that infrastructure to
multiple buffers by using the resource owner infrastructure.
This commit increases the size of the ResourceOwnerData struct, which appears
to have a just about measurable overhead in very extreme workloads. Medium
term we are planning to substantially shrink the size of
ResourceOwnerData. Short term the increase is small enough to not worry about
it for now.
Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/20221029025420.eplyow6k7tgu6he3@awork3.anarazel.de
Discussion: https://postgr.es/m/20221029200025.w7bvlgvamjfo6z44@awork3.anarazel.de
Diffstat (limited to 'src/backend/access')
| -rw-r--r-- | src/backend/access/transam/xact.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index 231af52cc92..6a837e1539d 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -2719,8 +2719,7 @@ AbortTransaction(void) pgstat_report_wait_end(); pgstat_progress_end_command(); - /* Clean up buffer I/O and buffer context locks, too */ - AbortBufferIO(); + /* Clean up buffer context locks, too */ UnlockBuffers(); /* Reset WAL record construction state */ @@ -5080,7 +5079,6 @@ AbortSubTransaction(void) pgstat_report_wait_end(); pgstat_progress_end_command(); - AbortBufferIO(); UnlockBuffers(); /* Reset WAL record construction state */ |