diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2014-11-10 15:56:08 -0300 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2014-11-10 15:56:08 -0300 |
| commit | 1e0b4365c22c9f8a1bc7a5f8339f770c767b402f (patch) | |
| tree | ea79265e74b5505cc6af57210d8b26e8ed20e3d2 /src/backend/access | |
| parent | 96a73fcdace57f0f631c1f56d1cb8a7a0773e93f (diff) | |
| download | postgresql-1e0b4365c22c9f8a1bc7a5f8339f770c767b402f.tar.gz postgresql-1e0b4365c22c9f8a1bc7a5f8339f770c767b402f.zip | |
Further code and wording tweaks in BRIN
Besides a couple of typo fixes, per David Rowley, Thom Brown, and Amit
Langote, and mentions of BRIN in the general CREATE INDEX page again per
David, this includes silencing MSVC compiler warnings (thanks Microsoft)
and an additional variable initialization per Coverity scanner.
Diffstat (limited to 'src/backend/access')
| -rw-r--r-- | src/backend/access/brin/README | 2 | ||||
| -rw-r--r-- | src/backend/access/brin/brin.c | 8 | ||||
| -rw-r--r-- | src/backend/access/brin/brin_tuple.c | 2 |
3 files changed, 7 insertions, 5 deletions
diff --git a/src/backend/access/brin/README b/src/backend/access/brin/README index 2619be8db56..636d96545b2 100644 --- a/src/backend/access/brin/README +++ b/src/backend/access/brin/README @@ -126,7 +126,7 @@ that page range is complete and new tuples belong in a new page range that hasn't yet been summarized. Those insertions do not create a new index entry; instead, the page range remains unsummarized until later. -Wehn VACUUM is run on the table, all unsummarized page ranges are +Whenever VACUUM is run on the table, all unsummarized page ranges are summarized. This action can also be invoked by the user via brin_summarize_new_values(). Both these procedures scan all the unsummarized ranges, and create a summary tuple. Again, this includes the diff --git a/src/backend/access/brin/brin.c b/src/backend/access/brin/brin.c index ae655497951..bd35cf6696a 100644 --- a/src/backend/access/brin/brin.c +++ b/src/backend/access/brin/brin.c @@ -107,9 +107,11 @@ brininsert(PG_FUNCTION_ARGS) BrinMemTuple *dtup; BlockNumber heapBlk; int keyno; - BrinTuple *tmptup PG_USED_FOR_ASSERTS_ONLY; - BrinMemTuple *tmpdtup PG_USED_FOR_ASSERTS_ONLY; - Size tmpsiz PG_USED_FOR_ASSERTS_ONLY; +#ifdef USE_ASSERT_CHECKING + BrinTuple *tmptup; + BrinMemTuple *tmpdtup; + Size tmpsiz; +#endif CHECK_FOR_INTERRUPTS(); diff --git a/src/backend/access/brin/brin_tuple.c b/src/backend/access/brin/brin_tuple.c index d895cb715cb..af649c00afc 100644 --- a/src/backend/access/brin/brin_tuple.c +++ b/src/backend/access/brin/brin_tuple.c @@ -95,7 +95,7 @@ brin_form_tuple(BrinDesc *brdesc, BlockNumber blkno, BrinMemTuple *tuple, BrinTuple *rettuple; int keyno; int idxattno; - uint16 phony_infomask; + uint16 phony_infomask = 0; bits8 *phony_nullbitmap; Size len, hoff, |