aboutsummaryrefslogtreecommitdiff
path: root/src/backend/access
diff options
context:
space:
mode:
authorAndres Freund <andres@anarazel.de>2015-05-08 18:00:01 +0200
committerAndres Freund <andres@anarazel.de>2015-05-08 19:24:14 +0200
commite8898e9169c851c2b8c98f981c1c4755a5758f8e (patch)
tree58f806e29a38e17e49838da4fa7d8c73dd8f996e /src/backend/access
parent53bb309d2d5a9432d2602c93ed18e58bd2924e15 (diff)
downloadpostgresql-e8898e9169c851c2b8c98f981c1c4755a5758f8e.tar.gz
postgresql-e8898e9169c851c2b8c98f981c1c4755a5758f8e.zip
Minor ON CONFLICT related comments and doc fixes.
Geoff Winkless, Stephen Frost, Peter Geoghegan and me.
Diffstat (limited to 'src/backend/access')
-rw-r--r--src/backend/access/heap/heapam.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 7ea9a77e7ea..1a8d2f2d0b5 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -2068,10 +2068,10 @@ FreeBulkInsertState(BulkInsertState bistate)
* Speculatively inserted tuples behave as "value locks" of short duration,
* used to implement INSERT .. ON CONFLICT.
*
- * Note that these options will be applied when inserting into the heap's
- * TOAST table, too, if the tuple requires any out-of-line data.
- * FIXME: Do we mark TOAST tuples as speculative too? What about confirming
- * or aborting them?
+ * Note that most of these options will be applied when inserting into the
+ * heap's TOAST table, too, if the tuple requires any out-of-line data. Only
+ * HEAP_INSERT_IS_SPECULATIVE is explicitly ignored, as the toast data does
+ * not partake in speculative insertion.
*
* The BulkInsertState object (if any; bistate can be NULL for default
* behavior) is also just passed through to RelationGetBufferForTuple.