diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-05-14 10:54:47 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-05-14 10:55:01 -0400 |
| commit | f04c9a61468904b6815b2bc73a48878817766e0e (patch) | |
| tree | b8eb1b9a131023b1ab0f7e151e036988d02eb8a3 /src/backend/catalog/namespace.c | |
| parent | 12ad38b3b4b5004001a525e0a0eda2ec45329e8e (diff) | |
| download | postgresql-f04c9a61468904b6815b2bc73a48878817766e0e.tar.gz postgresql-f04c9a61468904b6815b2bc73a48878817766e0e.zip | |
Standardize terminology for pg_statistic_ext entries.
Consistently refer to such an entry as a "statistics object", not just
"statistics" or "extended statistics". Previously we had a mismash of
terms, accompanied by utter confusion as to whether the term was
singular or plural. That's not only grating (at least to the ear of
a native English speaker) but could be outright misleading, eg in error
messages that seemed to be referring to multiple objects where only one
could be meant.
This commit fixes the code and a lot of comments (though I may have
missed a few). I also renamed two new SQL functions,
pg_get_statisticsextdef -> pg_get_statisticsobjdef
pg_statistic_ext_is_visible -> pg_statistics_obj_is_visible
to conform better with this terminology.
I have not touched the SGML docs other than fixing those function
names; the docs certainly need work but it seems like a separable task.
Discussion: https://postgr.es/m/22676.1494557205@sss.pgh.pa.us
Diffstat (limited to 'src/backend/catalog/namespace.c')
| -rw-r--r-- | src/backend/catalog/namespace.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/catalog/namespace.c b/src/backend/catalog/namespace.c index 5b339222af1..2a33eb73fa9 100644 --- a/src/backend/catalog/namespace.c +++ b/src/backend/catalog/namespace.c @@ -2087,12 +2087,12 @@ ConversionIsVisible(Oid conid) } /* - * get_statistics_oid - find a statistics by possibly qualified name + * get_statistics_object_oid - find a statistics object by possibly qualified name * * If not found, returns InvalidOid if missing_ok, else throws error */ Oid -get_statistics_oid(List *names, bool missing_ok) +get_statistics_object_oid(List *names, bool missing_ok) { char *schemaname; char *stats_name; @@ -2136,7 +2136,7 @@ get_statistics_oid(List *names, bool missing_ok) if (!OidIsValid(stats_oid) && !missing_ok) ereport(ERROR, (errcode(ERRCODE_UNDEFINED_OBJECT), - errmsg("statistics \"%s\" do not exist", + errmsg("statistics object \"%s\" does not exist", NameListToString(names)))); return stats_oid; @@ -4303,7 +4303,7 @@ pg_conversion_is_visible(PG_FUNCTION_ARGS) } Datum -pg_statistic_ext_is_visible(PG_FUNCTION_ARGS) +pg_statistics_obj_is_visible(PG_FUNCTION_ARGS) { Oid oid = PG_GETARG_OID(0); |