diff options
| author | Michael Paquier <michael@paquier.xyz> | 2023-07-20 15:18:25 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2023-07-20 15:18:25 +0900 |
| commit | 2a990abd79acea4717cc8f982a28f35b6b347ddb (patch) | |
| tree | 2a5b181b6d75fe5cd20367a327cd80f7e0cca868 /src/backend/commands/alter.c | |
| parent | 47556a0013fa64d44add2760577d49cf2eca4cd0 (diff) | |
| download | postgresql-2a990abd79acea4717cc8f982a28f35b6b347ddb.tar.gz postgresql-2a990abd79acea4717cc8f982a28f35b6b347ddb.zip | |
Add missing ObjectIdGetDatum() in syscache lookup calls for Oids
Based on how postgres.h foes the Oid <-> Datum conversion, there is no
existing bugs but let's be consistent. 17 spots have been noticed as
incorrectly passing down Oids rather than Datums. Aleksander got one,
Zhang two and I the rest.
Author: Michael Paquier, Aleksander Alekseev, Zhang Mingli
Discussion: https://postgr.es/m/ZLUhqsqQN1MOaxdw@paquier.xyz
Diffstat (limited to 'src/backend/commands/alter.c')
| -rw-r--r-- | src/backend/commands/alter.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/commands/alter.c b/src/backend/commands/alter.c index d64929df558..ff8d003876f 100644 --- a/src/backend/commands/alter.c +++ b/src/backend/commands/alter.c @@ -295,7 +295,8 @@ AlterObjectRename_internal(Relation rel, Oid objectId, const char *new_name) } else if (classId == SubscriptionRelationId) { - if (SearchSysCacheExists2(SUBSCRIPTIONNAME, MyDatabaseId, + if (SearchSysCacheExists2(SUBSCRIPTIONNAME, + ObjectIdGetDatum(MyDatabaseId), CStringGetDatum(new_name))) report_name_conflict(classId, new_name); |