diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2005-03-21 01:24:04 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2005-03-21 01:24:04 +0000 |
| commit | ee4ddac137b7c66e3bec6f74e3503236476cb16e (patch) | |
| tree | 3f8d12f472288b6758fc74802230374ef0e4b764 /src/backend/commands/analyze.c | |
| parent | fe7015f5e821d70428995f04726215fc79294f10 (diff) | |
| download | postgresql-ee4ddac137b7c66e3bec6f74e3503236476cb16e.tar.gz postgresql-ee4ddac137b7c66e3bec6f74e3503236476cb16e.zip | |
Convert index-related tuple handling routines from char 'n'/' ' to bool
convention for isnull flags. Also, remove the useless InsertIndexResult
return struct from index AM aminsert calls --- there is no reason for
the caller to know where in the index the tuple was inserted, and we
were wasting a palloc cycle per insert to deliver this uninteresting
value (plus nontrivial complexity in some AMs).
I forced initdb because of the change in the signature of the aminsert
routines, even though nothing really looks at those pg_proc entries...
Diffstat (limited to 'src/backend/commands/analyze.c')
| -rw-r--r-- | src/backend/commands/analyze.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c index b757512b463..94e1971a4df 100644 --- a/src/backend/commands/analyze.c +++ b/src/backend/commands/analyze.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.83 2005/03/16 21:38:05 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.84 2005/03/21 01:24:02 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -448,8 +448,8 @@ compute_index_stats(Relation onerel, double totalrows, { MemoryContext ind_context, old_context; - Datum attdata[INDEX_MAX_KEYS]; - char nulls[INDEX_MAX_KEYS]; + Datum values[INDEX_MAX_KEYS]; + bool isnull[INDEX_MAX_KEYS]; int ind, i; @@ -528,8 +528,8 @@ compute_index_stats(Relation onerel, double totalrows, FormIndexDatum(indexInfo, slot, estate, - attdata, - nulls); + values, + isnull); /* * Save just the columns we care about. @@ -539,8 +539,8 @@ compute_index_stats(Relation onerel, double totalrows, VacAttrStats *stats = thisdata->vacattrstats[i]; int attnum = stats->attr->attnum; - exprvals[tcnt] = attdata[attnum - 1]; - exprnulls[tcnt] = (nulls[attnum - 1] == 'n'); + exprvals[tcnt] = values[attnum - 1]; + exprnulls[tcnt] = isnull[attnum - 1]; tcnt++; } } |