diff options
| author | Noah Misch <noah@leadboat.com> | 2020-03-21 09:38:26 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2020-03-21 09:38:26 -0700 |
| commit | e629a01f6973688f77ecff964d9d6bea9bc4b374 (patch) | |
| tree | 0869ee42b7b4a282b0cd3475106449049115076b /src/backend/commands/cluster.c | |
| parent | d60ef94d7639b433a7bf9dd7d48aeb63194235d3 (diff) | |
| download | postgresql-e629a01f6973688f77ecff964d9d6bea9bc4b374.tar.gz postgresql-e629a01f6973688f77ecff964d9d6bea9bc4b374.zip | |
During heap rebuild, lock any TOAST index until end of transaction.
swap_relation_files() calls toast_get_valid_index() to find and lock
this index, just before swapping with the rebuilt TOAST index. The
latter function releases the lock before returning. Potential for
mischief is low; a concurrent session can issue ALTER INDEX ... SET
(fillfactor = ...), which is not alarming. Nonetheless, changing
pg_class.relfilenode without a lock is unconventional. Back-patch to
9.5 (all supported versions), because another fix needs this.
Discussion: https://postgr.es/m/20191226001521.GA1772687@rfd.leadboat.com
Diffstat (limited to 'src/backend/commands/cluster.c')
| -rw-r--r-- | src/backend/commands/cluster.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index 11ce1bb4046..fc1cea0236a 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -1489,7 +1489,7 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap, /* Get the associated valid index to be renamed */ toastidx = toast_get_valid_index(newrel->rd_rel->reltoastrelid, - AccessShareLock); + NoLock); /* rename the toast table ... */ snprintf(NewToastName, NAMEDATALEN, "pg_toast_%u", |