diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2017-03-09 15:18:59 -0500 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2017-03-28 21:59:23 -0400 |
| commit | 4cb824699e12c39fad97fb3d9085ced0d14c067c (patch) | |
| tree | 9a835d8efb7739e6436d3fc24b4b5a290b95df7d /src/backend/commands/copy.c | |
| parent | 66b764341ba12206f01e2600713bdc3abdb070b3 (diff) | |
| download | postgresql-4cb824699e12c39fad97fb3d9085ced0d14c067c.tar.gz postgresql-4cb824699e12c39fad97fb3d9085ced0d14c067c.zip | |
Cast result of copyObject() to correct type
copyObject() is declared to return void *, which allows easily assigning
the result independent of the input, but it loses all type checking.
If the compiler supports typeof or something similar, cast the result to
the input type. This creates a greater amount of type safety. In some
cases, where the result is assigned to a generic type such as Node * or
Expr *, new casts are now necessary, but in general casts are now
unnecessary in the normal case and indicate that something unusual is
happening.
Reviewed-by: Mark Dilger <hornschnorter@gmail.com>
Diffstat (limited to 'src/backend/commands/copy.c')
| -rw-r--r-- | src/backend/commands/copy.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index ab59be84552..0158eda5917 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -1470,7 +1470,7 @@ BeginCopy(ParseState *pstate, * function and is executed repeatedly. (See also the same hack in * DECLARE CURSOR and PREPARE.) XXX FIXME someday. */ - rewritten = pg_analyze_and_rewrite((RawStmt *) copyObject(raw_query), + rewritten = pg_analyze_and_rewrite(copyObject(raw_query), pstate->p_sourcetext, NULL, 0); /* check that we got back something we can work with */ |