diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-03-06 16:50:47 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-03-06 16:50:47 -0500 |
| commit | a8df75b0a470f477dad75a7408e429e10c13fc07 (patch) | |
| tree | 6b60473acf18e2758592cdfdb772cd2fcc0cd5ad /src/backend/commands/copy.c | |
| parent | e6477a8134ace06ef3a45a7ce15813cd398e72d8 (diff) | |
| download | postgresql-a8df75b0a470f477dad75a7408e429e10c13fc07.tar.gz postgresql-a8df75b0a470f477dad75a7408e429e10c13fc07.zip | |
Avoid dangling pointer to relation name in RLS code path in DoCopy().
With RLS active, "COPY tab TO ..." failed under -DRELCACHE_FORCE_RELEASE,
and would sometimes fail without that, because it used the relation name
directly from the relcache as part of the parsetree it's building. That
becomes a potentially-dangling pointer as soon as the relcache entry is
closed, a bit further down. Typical symptom if the relcache entry chanced
to get cleared would be "relation does not exist" error with a garbage
relation name, or possibly a core dump; but if you were really truly
unlucky, the COPY might copy from the wrong table.
Per report from Andrew Dunstan that regression tests fail with
-DRELCACHE_FORCE_RELEASE. The core tests now pass for me (but have
not tried "make check-world" yet).
Discussion: https://postgr.es/m/7b52f900-0579-cda9-ae2e-de5da17090e6@2ndQuadrant.com
Diffstat (limited to 'src/backend/commands/copy.c')
| -rw-r--r-- | src/backend/commands/copy.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 01a63c823e2..3102ab18c57 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -923,7 +923,8 @@ DoCopy(ParseState *pstate, const CopyStmt *stmt, * relation which we have opened and locked. */ from = makeRangeVar(get_namespace_name(RelationGetNamespace(rel)), - RelationGetRelationName(rel), -1); + pstrdup(RelationGetRelationName(rel)), + -1); /* Build query */ select = makeNode(SelectStmt); |