diff options
| author | Michael Paquier <michael@paquier.xyz> | 2018-12-23 16:42:22 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2018-12-23 16:42:22 +0900 |
| commit | bf491a9073e12ce1fc3e6facd0ae1308534df570 (patch) | |
| tree | 9cd8cd5ce2f5e21d32227592d82dd0fa830e37d2 /src/backend/commands/copy.c | |
| parent | 11a60d496147a1e1bbf6932bda53941c5a62ee1a (diff) | |
| download | postgresql-bf491a9073e12ce1fc3e6facd0ae1308534df570.tar.gz postgresql-bf491a9073e12ce1fc3e6facd0ae1308534df570.zip | |
Disable WAL-skipping optimization for COPY on views and foreign tables
COPY can skip writing WAL when loading data on a table which has been
created in the same transaction as the one loading the data, however
this cannot work on views or foreign table as this would result in
trying to flush relation files which do not exist. So disable the
optimization so as commands are able to work the same way with any
configuration of wal_level.
Tests are added to cover the different cases, which need to have
wal_level set to minimal to allow the problem to show up, and that is
not the default configuration.
Reported-by: Luis M. Carril, Etsuro Fujita
Author: Amit Langote, Michael Paquier
Reviewed-by: Etsuro Fujita
Discussion: https://postgr.es/m/15552-c64aa14c5c22f63c@postgresql.org
Backpatch-through: 10, where support for COPY on views has been added,
while v11 has added support for COPY on foreign tables.
Diffstat (limited to 'src/backend/commands/copy.c')
| -rw-r--r-- | src/backend/commands/copy.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 4311e160076..faa3f6357ae 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -2397,10 +2397,15 @@ CopyFrom(CopyState cstate) * possible to improve on this, but it does mean maintaining heap insert * option flags per partition and setting them when we first open the * partition. + * + * This optimization is not supported for relation types which do not + * have any physical storage, with foreign tables and views using + * INSTEAD OF triggers entering in this category. Partitioned tables + * are not supported as per the description above. *---------- */ /* createSubid is creation check, newRelfilenodeSubid is truncation check */ - if (cstate->rel->rd_rel->relkind != RELKIND_PARTITIONED_TABLE && + if (RELKIND_CAN_HAVE_STORAGE(cstate->rel->rd_rel->relkind) && (cstate->rel->rd_createSubid != InvalidSubTransactionId || cstate->rel->rd_newRelfilenodeSubid != InvalidSubTransactionId)) { |