diff options
| author | Noah Misch <noah@leadboat.com> | 2020-03-22 09:24:09 -0700 |
|---|---|---|
| committer | Noah Misch <noah@leadboat.com> | 2020-03-22 09:24:13 -0700 |
| commit | 63631ee64f84bae7feeb06b8417b628e82319ce2 (patch) | |
| tree | 35d8fe6f43ea3c9d7489062474c26ba599973c6b /src/backend/commands/createas.c | |
| parent | e4b0a02ef8c8c69f2a49f4ca86de12ef34e97ac3 (diff) | |
| download | postgresql-63631ee64f84bae7feeb06b8417b628e82319ce2.tar.gz postgresql-63631ee64f84bae7feeb06b8417b628e82319ce2.zip | |
Revert "Skip WAL for new relfilenodes, under wal_level=minimal."
This reverts commit cb2fd7eac285b1b0a24eeb2b8ed4456b66c5a09f. Per
numerous buildfarm members, it was incompatible with parallel query, and
a test case assumed LP64. Back-patch to 9.5 (all supported versions).
Discussion: https://postgr.es/m/20200321224920.GB1763544@rfd.leadboat.com
Diffstat (limited to 'src/backend/commands/createas.c')
| -rw-r--r-- | src/backend/commands/createas.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/backend/commands/createas.c b/src/backend/commands/createas.c index 568cfba08c0..4c1d909d380 100644 --- a/src/backend/commands/createas.c +++ b/src/backend/commands/createas.c @@ -553,13 +553,16 @@ intorel_startup(DestReceiver *self, int operation, TupleDesc typeinfo) myState->rel = intoRelationDesc; myState->reladdr = intoRelationAddr; myState->output_cid = GetCurrentCommandId(true); - myState->ti_options = TABLE_INSERT_SKIP_FSM; - myState->bistate = GetBulkInsertState(); /* - * Valid smgr_targblock implies something already wrote to the relation. - * This may be harmless, but this function hasn't planned for it. + * We can skip WAL-logging the insertions, unless PITR or streaming + * replication is in use. We can skip the FSM in any case. */ + myState->ti_options = TABLE_INSERT_SKIP_FSM | + (XLogIsNeeded() ? 0 : TABLE_INSERT_SKIP_WAL); + myState->bistate = GetBulkInsertState(); + + /* Not using WAL requires smgr_targblock be initially invalid */ Assert(RelationGetTargetBlock(intoRelationDesc) == InvalidBlockNumber); } |