aboutsummaryrefslogtreecommitdiff
path: root/src/backend/commands/functioncmds.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2012-05-30 23:47:57 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2012-05-30 23:47:57 -0400
commitad0009e7be27489f5acc0a36217d9ea8f3db2b14 (patch)
tree58c61395dce59e0f24c8850a8abe33d26358571a /src/backend/commands/functioncmds.c
parent33c6eaf78e692c0699e74a3883780d2edb68e4d7 (diff)
downloadpostgresql-ad0009e7be27489f5acc0a36217d9ea8f3db2b14.tar.gz
postgresql-ad0009e7be27489f5acc0a36217d9ea8f3db2b14.zip
Force PL and range-type support functions to be owned by a superuser.
We allow non-superusers to create procedural languages (with restrictions) and range datatypes. Previously, the automatically-created support functions for these objects ended up owned by the creating user. This represents a rather considerable security hazard, because the owning user might be able to alter a support function's definition in such a way as to crash the server, inject trojan-horse SQL code, or even execute arbitrary C code directly. It appears that right now the only actually exploitable problem is the infinite-recursion bug fixed in the previous patch for CVE-2012-2655. However, it's not hard to imagine that future additions of more ALTER FUNCTION capability might unintentionally open up new hazards. To forestall future problems, cause these support functions to be owned by the bootstrap superuser, not the user creating the parent object.
Diffstat (limited to 'src/backend/commands/functioncmds.c')
-rw-r--r--src/backend/commands/functioncmds.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c
index 5f1c19eb375..ff0836c141e 100644
--- a/src/backend/commands/functioncmds.c
+++ b/src/backend/commands/functioncmds.c
@@ -978,6 +978,7 @@ CreateFunction(CreateFunctionStmt *stmt, const char *queryString)
stmt->replace,
returnsSet,
prorettype,
+ GetUserId(),
languageOid,
languageValidator,
prosrc_str, /* converted to text later */