diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2011-08-14 15:40:29 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2011-08-14 15:40:29 -0400 |
| commit | 148f321eb4fe9030378ad21ba1be132084a9ab8f (patch) | |
| tree | dbb7aafadcffcf4d1b46806aba0c0accc892259b /src/backend/commands/indexcmds.c | |
| parent | 00fc5d22634df1a59c8a265dba3f12814dc343c3 (diff) | |
| download | postgresql-148f321eb4fe9030378ad21ba1be132084a9ab8f.tar.gz postgresql-148f321eb4fe9030378ad21ba1be132084a9ab8f.zip | |
Fix unsafe order of operations in foreign-table DDL commands.
When updating or deleting a system catalog tuple, it's necessary to acquire
RowExclusiveLock on the catalog before looking up the tuple; otherwise a
concurrent VACUUM FULL on the catalog might move the tuple to a different
TID before we can apply the update. Coding patterns that find the tuple
via a table scan aren't at risk here, but when obtaining the tuple from a
catalog cache, correct ordering is important; and several routines in
foreigncmds.c got it wrong. Noted while running the regression tests in
parallel with VACUUM FULL of assorted system catalogs.
For consistency I moved all the heap_open calls to the starts of their
functions, including a couple for which there was no actual bug.
Back-patch to 8.4 where foreigncmds.c was added.
Diffstat (limited to 'src/backend/commands/indexcmds.c')
0 files changed, 0 insertions, 0 deletions