diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2007-06-23 22:12:52 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2007-06-23 22:12:52 +0000 |
| commit | 46379d6e60f0f95e127a5045ca1fa74dfdc48a85 (patch) | |
| tree | 7d6fe8004575203b40a38184c154dc7f34a20345 /src/backend/commands/indexcmds.c | |
| parent | ec0bb02db8452d4098023f82b100ba68d8f7dfab (diff) | |
| download | postgresql-46379d6e60f0f95e127a5045ca1fa74dfdc48a85.tar.gz postgresql-46379d6e60f0f95e127a5045ca1fa74dfdc48a85.zip | |
Separate parse-analysis for utility commands out of parser/analyze.c
(which now deals only in optimizable statements), and put that code
into a new file parser/parse_utilcmd.c. This helps clarify and enforce
the design rule that utility statements shouldn't be processed during
the regular parse analysis phase; all interpretation of their meaning
should happen after they are given to ProcessUtility to execute.
(We need this because we don't retain any locks for a utility statement
that's in a plan cache, nor have any way to detect that it's stale.)
We are also able to simplify the API for parse_analyze() and related
routines, because they will now always return exactly one Query structure.
In passing, fix bug #3403 concerning trying to add a serial column to
an existing temp table (this is largely Heikki's work, but we needed
all that restructuring to make it safe).
Diffstat (limited to 'src/backend/commands/indexcmds.c')
| -rw-r--r-- | src/backend/commands/indexcmds.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index 24cb898b6a0..98dad737133 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.159 2007/06/03 17:06:16 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.160 2007/06/23 22:12:50 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -367,7 +367,7 @@ DefineIndex(RangeVar *heapRelation, /* * This shouldn't happen during CREATE TABLE, but can happen * during ALTER TABLE. Keep message in sync with - * transformIndexConstraints() in parser/analyze.c. + * transformIndexConstraints() in parser/parse_utilcmd.c. */ ereport(ERROR, (errcode(ERRCODE_UNDEFINED_COLUMN), |