diff options
| author | Michael Paquier <michael@paquier.xyz> | 2024-09-09 13:50:02 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-09-09 13:50:02 +0900 |
| commit | edb0f6e41b09d261326c5340acad3a2cea59d718 (patch) | |
| tree | d6408d708fbdaf2c591ac7ec998b3efe6dbe48de /src/backend/commands/indexcmds.c | |
| parent | dd20f950d4a37da3e71684f254fcdf4317b752b5 (diff) | |
| download | postgresql-edb0f6e41b09d261326c5340acad3a2cea59d718.tar.gz postgresql-edb0f6e41b09d261326c5340acad3a2cea59d718.zip | |
Fix waits of REINDEX CONCURRENTLY for indexes with predicates or expressions
As introduced by f9900df5f94, a REINDEX CONCURRENTLY job done for an
index with predicates or expressions would set PROC_IN_SAFE_IC in its
MyProc->statusFlags, causing it to be ignored by other concurrent
operations.
Such concurrent index rebuilds should never be ignored, as a predicate
or an expression could call a user-defined function that accesses a
different table than the table where the index is rebuilt.
A test that uses injection points is added, backpatched down to 17.
Michail has proposed a different test, but I have added something
simpler with more coverage.
Oversight in f9900df5f949.
Author: Michail Nikolaev
Discussion: https://postgr.es/m/CANtu0oj9A3kZVduFTG0vrmGnKB+DCHgEpzOp0qAyOgmks84j0w@mail.gmail.com
Backpatch-through: 14
Diffstat (limited to 'src/backend/commands/indexcmds.c')
| -rw-r--r-- | src/backend/commands/indexcmds.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/commands/indexcmds.c b/src/backend/commands/indexcmds.c index 21ed483b7fa..0b73d7e8730 100644 --- a/src/backend/commands/indexcmds.c +++ b/src/backend/commands/indexcmds.c @@ -3739,8 +3739,8 @@ ReindexRelationConcurrently(Oid relationOid, ReindexParams *params) save_nestlevel = NewGUCNestLevel(); /* determine safety of this index for set_indexsafe_procflags */ - idx->safe = (indexRel->rd_indexprs == NIL && - indexRel->rd_indpred == NIL); + idx->safe = (RelationGetIndexExpressions(indexRel) == NIL && + RelationGetIndexPredicate(indexRel) == NIL); idx->tableId = RelationGetRelid(heapRel); idx->amId = indexRel->rd_rel->relam; |