diff options
| author | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2024-02-05 11:01:30 +0200 |
|---|---|---|
| committer | Heikki Linnakangas <heikki.linnakangas@iki.fi> | 2024-02-05 11:03:28 +0200 |
| commit | 06f36bc01bf69f888896eb16025db8265b4df9be (patch) | |
| tree | 27848685d30b103483335b7983deabb3fc488534 /src/backend/commands/matview.c | |
| parent | f2fdea198b3d0ab30b9e8478a762488ecebabd88 (diff) | |
| download | postgresql-06f36bc01bf69f888896eb16025db8265b4df9be.tar.gz postgresql-06f36bc01bf69f888896eb16025db8265b4df9be.zip | |
Fix assertion if index is dropped during REFRESH CONCURRENTLY
When assertions are disabled, the built SQL statement is invalid and
you get a "syntax error". So this isn't a serious problem, but let's
avoid the assertion failure.
Backpatch to all supported versions.
Reviewed-by: Noah Misch
Diffstat (limited to 'src/backend/commands/matview.c')
| -rw-r--r-- | src/backend/commands/matview.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c index 03c9e97ca09..a5f8972170b 100644 --- a/src/backend/commands/matview.c +++ b/src/backend/commands/matview.c @@ -804,9 +804,12 @@ refresh_by_match_merge(Oid matviewOid, Oid tempOid, Oid relowner, * * ExecRefreshMatView() checks that after taking the exclusive lock on the * matview. So at least one unique index is guaranteed to exist here - * because the lock is still being held; so an Assert seems sufficient. + * because the lock is still being held. (One known exception is if a + * function called as part of refreshing the matview drops the index. + * That's a pretty silly thing to do.) */ - Assert(foundUniqueIndex); + if (!foundUniqueIndex) + elog(ERROR, "could not find suitable unique index on materialized view"); appendStringInfoString(&querybuf, " AND newdata.* OPERATOR(pg_catalog.*=) mv.*) " |