diff options
| author | Fujii Masao <fujii@postgresql.org> | 2020-11-12 11:26:55 +0900 |
|---|---|---|
| committer | Fujii Masao <fujii@postgresql.org> | 2020-11-12 11:26:55 +0900 |
| commit | b62e6056a05c60ce9edf93e87e1487ae50245a04 (patch) | |
| tree | 4918dec839ecce30ecc983147e9ae5267c723c33 /src/backend/commands/matview.c | |
| parent | 03f9cd93eaa5e3385b075bb1a17d2adde3e23edd (diff) | |
| download | postgresql-b62e6056a05c60ce9edf93e87e1487ae50245a04.tar.gz postgresql-b62e6056a05c60ce9edf93e87e1487ae50245a04.zip | |
pg_stat_statements: track number of rows processed by REFRESH MATERIALIZED VIEW.
Commit 6023b7ea71 allowed pg_stat_statements to track the number
of rows retrieved or affected by some utility commands including
CREATE MATERIALIZED VIEW. However it did not track the rowcount
of REFRESH MATERIALIZED VIEW. This commit allows pg_stat_statements
to track that.
To track that, this commit changes the query completion for
REFRESH MATERIALIZED VIEW so that it saves the rowcount. But note that
the rowcount is still not displayed in the command completion tag output.
That is, the display_rowcount flag of CMDTAG_REFRESH_MATERIALIZED_VIEW
command tag is left false in cmdtaglist.h. Otherwise, the change of
completion tag output might break applications using it.
Author: Katsuragi Yuta, Seino Yuki
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/71f6bc72f8bbaa06e701f8bd2562c347@oss.nttdata.com
Discussion: https://postgr.es/m/aadbfba9-e4bb-9531-6b3a-d13c31c8f4fe@oss.nttdata.com
Diffstat (limited to 'src/backend/commands/matview.c')
| -rw-r--r-- | src/backend/commands/matview.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c index f80a9e96a91..cfc63915f38 100644 --- a/src/backend/commands/matview.c +++ b/src/backend/commands/matview.c @@ -356,6 +356,17 @@ ExecRefreshMatView(RefreshMatViewStmt *stmt, const char *queryString, ObjectAddressSet(address, RelationRelationId, matviewOid); + /* + * Save the rowcount so that pg_stat_statements can track the total number + * of rows processed by REFRESH MATERIALIZED VIEW command. Note that we + * still don't display the rowcount in the command completion tag output, + * i.e., the display_rowcount flag of CMDTAG_REFRESH_MATERIALIZED_VIEW + * command tag is left false in cmdtaglist.h. Otherwise, the change of + * completion tag output might break applications using it. + */ + if (qc) + SetQueryCompletion(qc, CMDTAG_REFRESH_MATERIALIZED_VIEW, processed); + return address; } |