diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2012-11-26 15:55:51 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2012-11-26 15:55:51 -0500 |
| commit | 786afc1ce53126feecf4d02e96e7455669ccbf5a (patch) | |
| tree | 9f6aed8f4cd0dd70fc3fd80f4075f1823a0cc43f /src/backend/commands/prepare.c | |
| parent | eea6ada926c356087f3d3093dc39a71408ce26ec (diff) | |
| download | postgresql-786afc1ce53126feecf4d02e96e7455669ccbf5a.tar.gz postgresql-786afc1ce53126feecf4d02e96e7455669ccbf5a.zip | |
Revert patch for taking fewer snapshots.
This reverts commit d573e239f03506920938bf0be56c868d9c3416da, "Take fewer
snapshots". While that seemed like a good idea at the time, it caused
execution to use a snapshot that had been acquired before locking any of
the tables mentioned in the query. This created user-visible anomalies
that were not present in any prior release of Postgres, as reported by
Tomas Vondra. While this whole area could do with a redesign (since there
are related cases that have anomalies anyway), it doesn't seem likely that
any future patch would be reasonably back-patchable; and we don't want 9.2
to exhibit a behavior that's subtly unlike either past or future releases.
Hence, revert to prior code while we rethink the problem.
Diffstat (limited to 'src/backend/commands/prepare.c')
| -rw-r--r-- | src/backend/commands/prepare.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/commands/prepare.c b/src/backend/commands/prepare.c index 2d87b1c6907..e3de7f2f1db 100644 --- a/src/backend/commands/prepare.c +++ b/src/backend/commands/prepare.c @@ -289,7 +289,7 @@ ExecuteQuery(ExecuteStmt *stmt, IntoClause *intoClause, /* * Run the portal as appropriate. */ - PortalStart(portal, paramLI, eflags, true); + PortalStart(portal, paramLI, eflags, GetActiveSnapshot()); (void) PortalRun(portal, count, false, dest, dest, completionTag); |