diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2004-02-21 00:34:53 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2004-02-21 00:34:53 +0000 |
| commit | 59f9a0b9df0d224bb62ff8ec5b65e0b187655742 (patch) | |
| tree | 17fc75064e4925afc08824727e41dfcc9c29f3a3 /src/backend/commands/proclang.c | |
| parent | 1d567aee070b7a51fbdc74821237d5a5ae2caf8f (diff) | |
| download | postgresql-59f9a0b9df0d224bb62ff8ec5b65e0b187655742.tar.gz postgresql-59f9a0b9df0d224bb62ff8ec5b65e0b187655742.zip | |
Implement a solution to the 'Turkish locale downcases I incorrectly'
problem, per previous discussion. Make some additional changes to
centralize the knowledge of just how identifier downcasing is done,
in hopes of simplifying any future tweaking in this area.
Diffstat (limited to 'src/backend/commands/proclang.c')
| -rw-r--r-- | src/backend/commands/proclang.c | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/src/backend/commands/proclang.c b/src/backend/commands/proclang.c index 3c8e3185cb9..ba6929325bd 100644 --- a/src/backend/commands/proclang.c +++ b/src/backend/commands/proclang.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/proclang.c,v 1.52 2003/11/29 19:51:47 pgsql Exp $ + * $PostgreSQL: pgsql/src/backend/commands/proclang.c,v 1.53 2004/02/21 00:34:52 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -40,11 +40,12 @@ void CreateProceduralLanguage(CreatePLangStmt *stmt) { - char languageName[NAMEDATALEN]; + char *languageName; Oid procOid, valProcOid; Oid funcrettype; Oid typev[FUNC_MAX_ARGS]; + NameData langname; char nulls[Natts_pg_language]; Datum values[Natts_pg_language]; Relation rel; @@ -66,7 +67,7 @@ CreateProceduralLanguage(CreatePLangStmt *stmt) * Translate the language name and check that this language doesn't * already exist */ - case_translate_language_name(stmt->plname, languageName); + languageName = case_translate_language_name(stmt->plname); if (SearchSysCacheExists(LANGNAME, PointerGetDatum(languageName), @@ -124,12 +125,13 @@ CreateProceduralLanguage(CreatePLangStmt *stmt) } i = 0; - values[i++] = PointerGetDatum(languageName); - values[i++] = BoolGetDatum(true); /* lanispl */ - values[i++] = BoolGetDatum(stmt->pltrusted); - values[i++] = ObjectIdGetDatum(procOid); - values[i++] = ObjectIdGetDatum(valProcOid); - nulls[i] = 'n'; /* lanacl */ + namestrcpy(&langname, languageName); + values[i++] = NameGetDatum(&langname); /* lanname */ + values[i++] = BoolGetDatum(true); /* lanispl */ + values[i++] = BoolGetDatum(stmt->pltrusted); /* lanpltrusted */ + values[i++] = ObjectIdGetDatum(procOid); /* lanplcallfoid */ + values[i++] = ObjectIdGetDatum(valProcOid); /* lanvalidator */ + nulls[i] = 'n'; /* lanacl */ rel = heap_openr(LanguageRelationName, RowExclusiveLock); @@ -173,7 +175,7 @@ CreateProceduralLanguage(CreatePLangStmt *stmt) void DropProceduralLanguage(DropPLangStmt *stmt) { - char languageName[NAMEDATALEN]; + char *languageName; HeapTuple langTup; ObjectAddress object; @@ -189,7 +191,7 @@ DropProceduralLanguage(DropPLangStmt *stmt) * Translate the language name, check that this language exist and is * a PL */ - case_translate_language_name(stmt->plname, languageName); + languageName = case_translate_language_name(stmt->plname); langTup = SearchSysCache(LANGNAME, CStringGetDatum(languageName), |