aboutsummaryrefslogtreecommitdiff
path: root/src/backend/commands/tablecmds.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2003-01-08 22:06:23 +0000
committerTom Lane <tgl@sss.pgh.pa.us>2003-01-08 22:06:23 +0000
commit2d140d35a4170a6ad20dae5c01a381b5b4a4b6a3 (patch)
treea9cb21aae59bbc611d32e2a39f604cfc4df8707b /src/backend/commands/tablecmds.c
parent51d2e3bd6e5b3c9f3bb7aef465bd4f8ce2527d78 (diff)
downloadpostgresql-2d140d35a4170a6ad20dae5c01a381b5b4a4b6a3.tar.gz
postgresql-2d140d35a4170a6ad20dae5c01a381b5b4a4b6a3.zip
Reconsider old decision to try to constant-fold default and constraint
expressions before they are stored. This seems like not such a hot idea, particularly now that the constant-folder will try to inline SQL functions.
Diffstat (limited to 'src/backend/commands/tablecmds.c')
-rw-r--r--src/backend/commands/tablecmds.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 3f9cad16ce4..84ea31885d6 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
- * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.64 2002/12/30 19:45:17 tgl Exp $
+ * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.65 2003/01/08 22:06:23 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@@ -2756,7 +2756,10 @@ AlterTableAddCheckConstraint(Relation rel, Constraint *constr)
elog(ERROR, "cannot use aggregate function in CHECK constraint expression");
/*
- * Might as well try to reduce any constant expressions.
+ * Might as well try to reduce any constant expressions, so as to
+ * minimize overhead while testing the constraint at each row.
+ *
+ * Note that the stored form of the constraint will NOT be const-folded.
*/
expr = eval_const_expressions(expr);