diff options
| author | Robert Haas <rhaas@postgresql.org> | 2011-04-13 18:07:14 -0700 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2011-04-13 18:17:52 -0700 |
| commit | 39a68e5c6ca7b41b889e773ca58535324af69630 (patch) | |
| tree | 83abdbf0e7496a1ec1addc0f1e09fc6219f3af71 /src/backend/commands/tablecmds.c | |
| parent | eca75a12a27d28b972fc269c1c8813cd8eb15441 (diff) | |
| download | postgresql-39a68e5c6ca7b41b889e773ca58535324af69630.tar.gz postgresql-39a68e5c6ca7b41b889e773ca58535324af69630.zip | |
Fix toast table creation.
Instead of using slightly-too-clever heuristics to decide when we must
create a TOAST table, just check whether one is needed every time the
table is altered. Checking whether a toast table is needed is cheap
enough that we needn't worry about doing it on every ALTER TABLE command,
and the previous coding is apparently prone to accidental breakage:
commit 04e17bae50a73af524731fa11210d5c3f7d8e1f9 broken ALTER TABLE ..
SET STORAGE, which moved some actions from AT_PASS_COL_ATTRS to
AT_PASS_MISC, and commit 6c5723998594dffa5d47c3cf8c96ccf89c033aae broke
ALTER TABLE .. ADD COLUMN by changing the way that adding columns
recurses into child tables.
Noah Misch, with one comment change by me
Diffstat (limited to 'src/backend/commands/tablecmds.c')
| -rw-r--r-- | src/backend/commands/tablecmds.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 6afebc728f5..d3692754959 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -3022,18 +3022,12 @@ ATRewriteCatalogs(List **wqueue, LOCKMODE lockmode) } } - /* - * Check to see if a toast table must be added, if we executed any - * subcommands that might have added a column or changed column storage. - */ + /* Check to see if a toast table must be added. */ foreach(ltab, *wqueue) { AlteredTableInfo *tab = (AlteredTableInfo *) lfirst(ltab); - if (tab->relkind == RELKIND_RELATION && - (tab->subcmds[AT_PASS_ADD_COL] || - tab->subcmds[AT_PASS_ALTER_TYPE] || - tab->subcmds[AT_PASS_COL_ATTRS])) + if (tab->relkind == RELKIND_RELATION) AlterTableCreateToastTable(tab->relid, (Datum) 0); } } |