diff options
| author | Michael Paquier <michael@paquier.xyz> | 2024-01-24 14:20:08 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2024-01-24 14:20:08 +0900 |
| commit | 51193e7a7d333e2f19048c97a336da436b7d97e9 (patch) | |
| tree | f7114ea9d7c26b692923be7b3f368ba9b0831ad2 /src/backend/commands/tablecmds.c | |
| parent | 8b31b689f4db9fca726a8d1bab20b89ebb3fa0b1 (diff) | |
| download | postgresql-51193e7a7d333e2f19048c97a336da436b7d97e9.tar.gz postgresql-51193e7a7d333e2f19048c97a336da436b7d97e9.zip | |
Fix ALTER TABLE .. ADD COLUMN with complex inheritance trees
This command, when used to add a column on a parent table with a complex
inheritance tree, tried to update multiple times the same tuple in
pg_attribute for a child table when incrementing attinhcount, causing
failures with "tuple already updated by self" because of a missing
CommandCounterIncrement() between two updates.
This exists for a rather long time, so backpatch all the way down.
Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/18297-b04cd83a55b51e35@postgresql.org
Backpatch-through: 12
Diffstat (limited to 'src/backend/commands/tablecmds.c')
| -rw-r--r-- | src/backend/commands/tablecmds.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index da705ae468b..25f3a3d1948 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -6866,6 +6866,10 @@ ATExecAddColumn(List **wqueue, AlteredTableInfo *tab, Relation rel, colDef->colname, RelationGetRelationName(rel)))); table_close(attrdesc, RowExclusiveLock); + + /* Make the child column change visible */ + CommandCounterIncrement(); + return InvalidObjectAddress; } } |