diff options
| author | Michael Paquier <michael@paquier.xyz> | 2018-12-17 12:44:02 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2018-12-17 12:44:02 +0900 |
| commit | c7567e09d5d1e6357b95ad16f2bc4dd6affa07f3 (patch) | |
| tree | 3c19d04887e471210244881869a76906213a04ab /src/backend/commands/tablecmds.c | |
| parent | 5812be7b63cfaf09d982a401ca8f72d150c0f721 (diff) | |
| download | postgresql-c7567e09d5d1e6357b95ad16f2bc4dd6affa07f3.tar.gz postgresql-c7567e09d5d1e6357b95ad16f2bc4dd6affa07f3.zip | |
Fix use-after-free bug when renaming constraints
This is an oversight from recent commit b13fd344. While on it, tweak
the previous test with a better name for the renamed primary key.
Detected by buildfarm member prion which forces relation cache release
with -DRELCACHE_FORCE_RELEASE. Back-patch down to 9.4 as the previous
commit.
Diffstat (limited to 'src/backend/commands/tablecmds.c')
| -rw-r--r-- | src/backend/commands/tablecmds.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 6ff3d46fb29..c8df816f6aa 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -2487,12 +2487,12 @@ rename_constraint_internal(Oid myrelid, if (targetrelation) { - relation_close(targetrelation, NoLock); /* close rel but keep lock */ - /* * Invalidate relcache so as others can see the new constraint name. */ CacheInvalidateRelcache(targetrelation); + + relation_close(targetrelation, NoLock); /* close rel but keep lock */ } return address; |