diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2022-07-28 14:13:37 +1200 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2022-07-28 14:26:12 +1200 |
| commit | 4fc6b6eefcf98f79211bb790ee890ebcb05c178d (patch) | |
| tree | fe68b3a07db024878cd76723331336c28924cd75 /src/backend/commands/tablespace.c | |
| parent | 5253519b27d3393c07eb04470f04462c67ad94a9 (diff) | |
| download | postgresql-4fc6b6eefcf98f79211bb790ee890ebcb05c178d.tar.gz postgresql-4fc6b6eefcf98f79211bb790ee890ebcb05c178d.zip | |
Fix get_dirent_type() for symlinks on MinGW/MSYS.
On Windows with MSVC, get_dirent_type() was recently made to return
DT_LNK for junction points by commit 9d3444dc, which fixed some
defective dirent.c code.
On Windows with Cygwin, get_dirent_type() already worked for symlinks,
as it does on POSIX systems, because Cygwin has its own fake symlinks
that behave like POSIX (on closer inspection, Cygwin's dirent has the
BSD d_type extension but it's probably always DT_UNKNOWN, so we fall
back to lstat(), which understands Cygwin symlinks with S_ISLNK()).
On Windows with MinGW/MSYS, we need extra code, because the MinGW
runtime has its own readdir() without d_type, and the lstat()-based
fallback has no knowledge of our convention for treating junctions as
symlinks.
Back-patch to 14, where get_dirent_type() landed.
Reported-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/b9ddf605-6b36-f90d-7c30-7b3e95c46276%40dunslane.net
Diffstat (limited to 'src/backend/commands/tablespace.c')
0 files changed, 0 insertions, 0 deletions