diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2022-07-01 10:51:45 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2022-07-01 11:23:15 +0200 |
| commit | d746021de18baf0f29eff0388204a0664f41eb8b (patch) | |
| tree | 21074e7935e62cd054e702d79e5c1fe7c8544733 /src/backend/commands/typecmds.c | |
| parent | 7c2d6f8d3400edab2b91de7765db9ec71235fac9 (diff) | |
| download | postgresql-d746021de18baf0f29eff0388204a0664f41eb8b.tar.gz postgresql-d746021de18baf0f29eff0388204a0664f41eb8b.zip | |
Add construct_array_builtin, deconstruct_array_builtin
There were many calls to construct_array() and deconstruct_array() for
built-in types, for example, when dealing with system catalog columns.
These all hardcoded the type attributes necessary to pass to these
functions.
To simplify this a bit, add construct_array_builtin(),
deconstruct_array_builtin() as wrappers that centralize this hardcoded
knowledge. This simplifies many call sites and reduces the amount of
hardcoded stuff that is spread around.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/2914356f-9e5f-8c59-2995-5997fc48bcba%40enterprisedb.com
Diffstat (limited to 'src/backend/commands/typecmds.c')
| -rw-r--r-- | src/backend/commands/typecmds.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/backend/commands/typecmds.c b/src/backend/commands/typecmds.c index 9b92b042420..4f5e7c7ccb2 100644 --- a/src/backend/commands/typecmds.c +++ b/src/backend/commands/typecmds.c @@ -1893,12 +1893,9 @@ makeMultirangeConstructors(const char *name, Oid namespace, /* n-arg constructor - vararg */ argtypes = buildoidvector(&rangeArrayOid, 1); allParamTypes = ObjectIdGetDatum(rangeArrayOid); - allParameterTypes = construct_array(&allParamTypes, - 1, OIDOID, - sizeof(Oid), true, TYPALIGN_INT); + allParameterTypes = construct_array_builtin(&allParamTypes, 1, OIDOID); paramModes = CharGetDatum(FUNC_PARAM_VARIADIC); - parameterModes = construct_array(¶mModes, 1, CHAROID, - 1, true, TYPALIGN_CHAR); + parameterModes = construct_array_builtin(¶mModes, 1, CHAROID); myself = ProcedureCreate(name, /* name: same as multirange type */ namespace, false, /* replace */ |