diff options
| author | Michael Paquier <michael@paquier.xyz> | 2023-07-20 15:18:25 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2023-07-20 15:18:25 +0900 |
| commit | 2a990abd79acea4717cc8f982a28f35b6b347ddb (patch) | |
| tree | 2a5b181b6d75fe5cd20367a327cd80f7e0cca868 /src/backend/commands/user.c | |
| parent | 47556a0013fa64d44add2760577d49cf2eca4cd0 (diff) | |
| download | postgresql-2a990abd79acea4717cc8f982a28f35b6b347ddb.tar.gz postgresql-2a990abd79acea4717cc8f982a28f35b6b347ddb.zip | |
Add missing ObjectIdGetDatum() in syscache lookup calls for Oids
Based on how postgres.h foes the Oid <-> Datum conversion, there is no
existing bugs but let's be consistent. 17 spots have been noticed as
incorrectly passing down Oids rather than Datums. Aleksander got one,
Zhang two and I the rest.
Author: Michael Paquier, Aleksander Alekseev, Zhang Mingli
Discussion: https://postgr.es/m/ZLUhqsqQN1MOaxdw@paquier.xyz
Diffstat (limited to 'src/backend/commands/user.c')
| -rw-r--r-- | src/backend/commands/user.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/commands/user.c b/src/backend/commands/user.c index 6b42d4fc34a..ce77a055e58 100644 --- a/src/backend/commands/user.c +++ b/src/backend/commands/user.c @@ -1935,7 +1935,7 @@ AddRoleMems(Oid currentUserId, const char *rolename, Oid roleid, HeapTuple mrtup; Form_pg_authid mrform; - mrtup = SearchSysCache1(AUTHOID, memberid); + mrtup = SearchSysCache1(AUTHOID, ObjectIdGetDatum(memberid)); if (!HeapTupleIsValid(mrtup)) elog(ERROR, "cache lookup failed for role %u", memberid); mrform = (Form_pg_authid) GETSTRUCT(mrtup); |