diff options
| author | Nathan Bossart <nathan@postgresql.org> | 2023-07-13 21:13:45 -0700 |
|---|---|---|
| committer | Nathan Bossart <nathan@postgresql.org> | 2023-07-13 21:13:45 -0700 |
| commit | a0363ab7aafda7d16ae59e72d86866c02ad3d657 (patch) | |
| tree | b682bf6ca6b4a56e17f03a4f5b9f12fcb4f9b86a /src/backend/commands/variable.c | |
| parent | 9987a7bf34061ed5cffc4e5113da056358976e94 (diff) | |
| download | postgresql-a0363ab7aafda7d16ae59e72d86866c02ad3d657.tar.gz postgresql-a0363ab7aafda7d16ae59e72d86866c02ad3d657.zip | |
Fix privilege check for SET SESSION AUTHORIZATION.
Presently, the privilege check for SET SESSION AUTHORIZATION checks
whether the original authenticated role was a superuser at
connection start time. Even if the role loses the superuser
attribute, its existing sessions are permitted to change session
authorization to any role.
This commit modifies this privilege check to verify the original
authenticated role currently has superuser. In the event that the
authenticated role loses superuser within a session authorization
change, the authorization change will remain in effect, which means
the user can still take advantage of the target role's privileges.
However, [RE]SET SESSION AUTHORIZATION will only permit switching
to the original authenticated role.
Author: Joseph Koshakow
Discussion: https://postgr.es/m/CAAvxfHc-HHzONQ2oXdvhFF9ayRnidPwK%2BfVBhRzaBWYYLVQL-g%40mail.gmail.com
Diffstat (limited to 'src/backend/commands/variable.c')
| -rw-r--r-- | src/backend/commands/variable.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/commands/variable.c b/src/backend/commands/variable.c index 071bef63754..a88cf5f118f 100644 --- a/src/backend/commands/variable.c +++ b/src/backend/commands/variable.c @@ -854,7 +854,7 @@ check_session_authorization(char **newval, void **extra, GucSource source) * authenticated user's superuserness is what matters. */ if (roleid != GetAuthenticatedUserId() && - !GetAuthenticatedUserIsSuperuser()) + !superuser_arg(GetAuthenticatedUserId())) { if (source == PGC_S_TEST) { |