diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2019-02-17 12:37:31 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2019-02-17 12:37:31 -0500 |
| commit | 4eca1905d34b34a48b80553262edc81048fd7dfe (patch) | |
| tree | 08974db0992f59fd7775294948aad8786303b06d /src/backend/commands/view.c | |
| parent | d43a1ff8f28c2895ac24326f0c8bbf2088f28cc5 (diff) | |
| download | postgresql-4eca1905d34b34a48b80553262edc81048fd7dfe.tar.gz postgresql-4eca1905d34b34a48b80553262edc81048fd7dfe.zip | |
Fix CREATE VIEW to allow zero-column views.
We should logically have allowed this case when we allowed zero-column
tables, but it was overlooked.
Although this might be thought a feature addition, it's really a bug
fix, because it was possible to create a zero-column view via
the convert-table-to-view code path, and then you'd have a situation
where dump/reload would fail. Hence, back-patch to all supported
branches.
Arrange the added test cases to provide coverage of the related
pg_dump code paths (since these views will be dumped and reloaded
during the pg_upgrade regression test). I also made them test
the case where pg_dump has to postpone the view rule into post-data,
which disturbingly had no regression coverage before.
Report and patch by Ashutosh Sharma (test case by me)
Discussion: https://postgr.es/m/CAE9k0PkmHdeSaeZt2ujnb_cKucmK3sDDceDzw7+d5UZoNJPYOg@mail.gmail.com
Diffstat (limited to 'src/backend/commands/view.c')
| -rw-r--r-- | src/backend/commands/view.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c index 2f0ba12d222..2510b9c3d25 100644 --- a/src/backend/commands/view.c +++ b/src/backend/commands/view.c @@ -111,11 +111,6 @@ DefineVirtualRelation(RangeVar *relation, List *tlist, bool replace, } } - if (attrList == NIL) - ereport(ERROR, - (errcode(ERRCODE_INVALID_TABLE_DEFINITION), - errmsg("view must have at least one column"))); - /* * Look up, check permissions on, and lock the creation namespace; also * check for a preexisting view with the same name. This will also set |