diff options
| author | Robert Haas <rhaas@postgresql.org> | 2015-03-11 15:26:43 -0400 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2015-03-11 15:26:43 -0400 |
| commit | bc93ac12c2544b6b3a68b6cb0282e0828fa14a34 (patch) | |
| tree | c55d425c5973276495a1300d0c9f77f91de10566 /src/backend/commands/view.c | |
| parent | c6b3c939b7e0f1d35f4ed4996e71420a993810d2 (diff) | |
| download | postgresql-bc93ac12c2544b6b3a68b6cb0282e0828fa14a34.tar.gz postgresql-bc93ac12c2544b6b3a68b6cb0282e0828fa14a34.zip | |
Require non-NULL pstate for all addRangeTableEntryFor* functions.
Per discussion, it's better to have a consistent coding rule here.
Michael Paquier, per a node from Greg Stark referencing an old post
from Tom Lane.
Diffstat (limited to 'src/backend/commands/view.c')
| -rw-r--r-- | src/backend/commands/view.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/backend/commands/view.c b/src/backend/commands/view.c index 6f2a749756c..efa4be1732f 100644 --- a/src/backend/commands/view.c +++ b/src/backend/commands/view.c @@ -345,6 +345,7 @@ UpdateRangeTableOfViewParse(Oid viewOid, Query *viewParse) List *new_rt; RangeTblEntry *rt_entry1, *rt_entry2; + ParseState *pstate; /* * Make a copy of the given parsetree. It's not so much that we don't @@ -356,6 +357,9 @@ UpdateRangeTableOfViewParse(Oid viewOid, Query *viewParse) */ viewParse = (Query *) copyObject(viewParse); + /* Create a dummy ParseState for addRangeTableEntryForRelation */ + pstate = make_parsestate(NULL); + /* need to open the rel for addRangeTableEntryForRelation */ viewRel = relation_open(viewOid, AccessShareLock); @@ -363,10 +367,10 @@ UpdateRangeTableOfViewParse(Oid viewOid, Query *viewParse) * Create the 2 new range table entries and form the new range table... * OLD first, then NEW.... */ - rt_entry1 = addRangeTableEntryForRelation(NULL, viewRel, + rt_entry1 = addRangeTableEntryForRelation(pstate, viewRel, makeAlias("old", NIL), false, false); - rt_entry2 = addRangeTableEntryForRelation(NULL, viewRel, + rt_entry2 = addRangeTableEntryForRelation(pstate, viewRel, makeAlias("new", NIL), false, false); /* Must override addRangeTableEntry's default access-check flags */ |