diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2021-11-26 09:57:23 +0100 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2021-11-26 09:57:23 +0100 |
| commit | 36cb5e7c512bef394c9288786c62ef0eb1e891ba (patch) | |
| tree | f5825813ce0af3e2d1a8bfc1df6dbe86aa883603 /src/backend/commands | |
| parent | 99e4d24a9d77e7bb87e15b318e96dc36651a7da2 (diff) | |
| download | postgresql-36cb5e7c512bef394c9288786c62ef0eb1e891ba.tar.gz postgresql-36cb5e7c512bef394c9288786c62ef0eb1e891ba.zip | |
Update comments
Various places wanted to point out that tuple descriptors don't
contain the variable-length fields of pg_attribute. This started when
attacl was added, but more fields have been added since, and these
comments haven't been kept up to date consistently. Reword so that
the purpose is clearer and we don't have to keep updating them.
Diffstat (limited to 'src/backend/commands')
| -rw-r--r-- | src/backend/commands/tablecmds.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 5e9cae26a0b..c35f09998c4 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -6734,7 +6734,10 @@ ATExecAddColumn(List **wqueue, AlteredTableInfo *tab, Relation rel, list_make1_oid(rel->rd_rel->reltype), 0); - /* construct new attribute's pg_attribute entry */ + /* + * Construct new attribute's pg_attribute entry. (Variable-length fields + * are handled by InsertPgAttributeTuples().) + */ attribute.attrelid = myrelid; namestrcpy(&(attribute.attname), colDef->colname); attribute.atttypid = typeOid; @@ -6758,8 +6761,6 @@ ATExecAddColumn(List **wqueue, AlteredTableInfo *tab, Relation rel, attribute.attinhcount = colDef->inhcount; attribute.attcollation = collOid; - /* attribute.attacl is handled by InsertPgAttributeTuples() */ - ReleaseSysCache(typeTuple); tupdesc = CreateTupleDesc(lengthof(aattr), (FormData_pg_attribute **) &aattr); |