diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2024-11-28 08:19:22 +0100 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2024-11-28 08:27:20 +0100 |
| commit | 7f798aca1d5df290aafad41180baea0ae311b4ee (patch) | |
| tree | b4c8132ec85c21f6c72308b5857defd70958de69 /src/backend/executor/nodeAgg.c | |
| parent | 97525bc5c8ffb31475d23955d08e9ec9c1408f33 (diff) | |
| download | postgresql-7f798aca1d5df290aafad41180baea0ae311b4ee.tar.gz postgresql-7f798aca1d5df290aafad41180baea0ae311b4ee.zip | |
Remove useless casts to (void *)
Many of them just seem to have been copied around for no real reason.
Their presence causes (small) risks of hiding actual type mismatches
or silently discarding qualifiers
Discussion: https://www.postgresql.org/message-id/flat/461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org
Diffstat (limited to 'src/backend/executor/nodeAgg.c')
| -rw-r--r-- | src/backend/executor/nodeAgg.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/backend/executor/nodeAgg.c b/src/backend/executor/nodeAgg.c index 53ead77ece8..84d33fdebc6 100644 --- a/src/backend/executor/nodeAgg.c +++ b/src/backend/executor/nodeAgg.c @@ -1088,7 +1088,7 @@ finalize_aggregate(AggState *aggstate, InitFunctionCallInfoData(*fcinfo, &peragg->finalfn, numFinalArgs, pertrans->aggCollation, - (void *) aggstate, NULL); + (Node *) aggstate, NULL); /* Fill in the transition state value */ fcinfo->args[0].value = @@ -1440,12 +1440,11 @@ find_cols_walker(Node *node, FindColsContext *context) { Assert(!context->is_aggref); context->is_aggref = true; - expression_tree_walker(node, find_cols_walker, (void *) context); + expression_tree_walker(node, find_cols_walker, context); context->is_aggref = false; return false; } - return expression_tree_walker(node, find_cols_walker, - (void *) context); + return expression_tree_walker(node, find_cols_walker, context); } /* @@ -4101,7 +4100,7 @@ build_pertrans_for_aggref(AggStatePerTrans pertrans, &pertrans->transfn, numTransArgs, pertrans->aggCollation, - (void *) aggstate, NULL); + (Node *) aggstate, NULL); /* get info about the state value's datatype */ get_typlenbyval(aggtranstype, @@ -4121,7 +4120,7 @@ build_pertrans_for_aggref(AggStatePerTrans pertrans, &pertrans->serialfn, 1, InvalidOid, - (void *) aggstate, NULL); + (Node *) aggstate, NULL); } if (OidIsValid(aggdeserialfn)) @@ -4137,7 +4136,7 @@ build_pertrans_for_aggref(AggStatePerTrans pertrans, &pertrans->deserialfn, 2, InvalidOid, - (void *) aggstate, NULL); + (Node *) aggstate, NULL); } /* |