diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-12-24 21:37:46 -0500 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-12-24 21:37:46 -0500 |
commit | 6f7e972e2f44912b15d4a8884534745b1d5f492b (patch) | |
tree | 7c764551fb5428469f8d955daedb12dc2eeb4e63 /src/backend/executor/nodeFunctionscan.c | |
parent | 0217ad806637fed6b3bce759169724f31b66256d (diff) | |
download | postgresql-6f7e972e2f44912b15d4a8884534745b1d5f492b.tar.gz postgresql-6f7e972e2f44912b15d4a8884534745b1d5f492b.zip |
Avoid time-of-day-dependent failure in log rotation test.
Buildfarm members pogona and petalura have shown a failure when
pg_ctl/t/004_logrotate.pl starts just before local midnight.
The default rotate-at-midnight behavior occurs just before the
Perl script examines current_logfiles, so it figures that the
rotation it's already requested has occurred ... but in reality,
that rotation happens just after it looks, so the expected new
log data goes into a different file than the one it's examining.
In HEAD, src/test/kerberos/t/001_auth.pl has acquired similar code
that evidently has a related failure mode. Besides being quite new,
few buildfarm critters run that test, so it's unsurprising that
we've not yet seen a failure there.
Fix both cases by setting log_rotation_age = 0 so that no time-based
rotation can occur. Also absorb 004_logrotate.pl's decision to
set lc_messages = 'C' into the kerberos test, in hopes that it will
work in non-English prevailing locales.
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pogona&dt=2020-12-24%2022%3A10%3A04
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura&dt=2020-02-01%2022%3A20%3A04
Diffstat (limited to 'src/backend/executor/nodeFunctionscan.c')
0 files changed, 0 insertions, 0 deletions