diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-07-09 19:26:19 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-07-09 19:26:19 -0400 |
| commit | 7ddac4e8febac38f49a90cde6e57638a45e825e0 (patch) | |
| tree | ce34ae98958e1d076cd974e353cd52de6e3553c4 /src/backend/executor/nodeGroup.c | |
| parent | 6532ca57ad326d6ac9200eff3f93c3b036626bb6 (diff) | |
| download | postgresql-7ddac4e8febac38f49a90cde6e57638a45e825e0.tar.gz postgresql-7ddac4e8febac38f49a90cde6e57638a45e825e0.zip | |
Avoid emitting a bogus WAL record when recycling an all-zero btree page.
Commit fafa374f2 caused _bt_getbuf() to possibly emit a WAL record for
a page that it was about to recycle. However, it failed to distinguish
all-zero pages from dead pages, which is important because only the
latter have valid btpo.xact values, or indeed any special space at all.
Recycling an all-zero page with XLogStandbyInfoActive() enabled therefore
led to an Assert failure, or to emission of a WAL record containing a
bogus cutoff XID, which might lead to unnecessary query cancellations
on hot standby servers.
Per reports from Antonin Houska and 自己. Amit Kapila was first to
propose this fix, and Robert Haas, myself, and Kyotaro Horiguchi
reviewed it at various times.
This is an old bug, so back-patch to all supported branches.
Discussion: https://postgr.es/m/2628.1474272158@localhost
Discussion: https://postgr.es/m/48875502.f4a0.1635f0c27b0.Coremail.zoulx1982@163.com
Diffstat (limited to 'src/backend/executor/nodeGroup.c')
0 files changed, 0 insertions, 0 deletions