diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2000-08-22 04:06:22 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2000-08-22 04:06:22 +0000 |
| commit | 0147b1934f251183d3614bca011bf21205890835 (patch) | |
| tree | ed7df11ba0ecbdae22095a2eeacbd204dcdca1b8 /src/backend/executor/nodeHash.c | |
| parent | 94e90d9a86a186c83891fe4ce3e343bcf1860053 (diff) | |
| download | postgresql-0147b1934f251183d3614bca011bf21205890835.tar.gz postgresql-0147b1934f251183d3614bca011bf21205890835.zip | |
Fix a many-legged critter reported by chifungfan@yahoo.com: under the
right circumstances a hash join executed as a DECLARE CURSOR/FETCH
query would crash the backend. Problem as seen in current sources was
that the hash tables were stored in a context that was a child of
TransactionCommandContext, which got zapped at completion of the FETCH
command --- but cursor cleanup executed at COMMIT expected the tables
to still be valid. I haven't chased down the details as seen in 7.0.*
but I'm sure it's the same general problem.
Diffstat (limited to 'src/backend/executor/nodeHash.c')
| -rw-r--r-- | src/backend/executor/nodeHash.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/backend/executor/nodeHash.c b/src/backend/executor/nodeHash.c index f63ffe49435..682afdba4af 100644 --- a/src/backend/executor/nodeHash.c +++ b/src/backend/executor/nodeHash.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * - * $Id: nodeHash.c,v 1.50 2000/07/17 03:04:53 tgl Exp $ + * $Id: nodeHash.c,v 1.51 2000/08/22 04:06:19 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -334,7 +334,8 @@ ExecHashTableCreate(Hash *node) /* ---------------- * Initialize the hash table control block. - * The hashtable control block is just palloc'd from executor memory. + * The hashtable control block is just palloc'd from the executor's + * per-query memory context. * ---------------- */ hashtable = (HashJoinTable) palloc(sizeof(HashTableData)); @@ -361,7 +362,7 @@ ExecHashTableCreate(Hash *node) * working storage. See notes in executor/hashjoin.h. * ---------------- */ - hashtable->hashCxt = AllocSetContextCreate(TransactionCommandContext, + hashtable->hashCxt = AllocSetContextCreate(CurrentMemoryContext, "HashTableContext", ALLOCSET_DEFAULT_MINSIZE, ALLOCSET_DEFAULT_INITSIZE, |