diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2018-11-03 11:05:35 +1300 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2018-11-03 11:05:35 +1300 |
| commit | 1ce4a807e25bcd726e34b8d3ba0338e9299f9a87 (patch) | |
| tree | e5cbfe067878303940a6b027756d10b0f64ebe4f /src/backend/executor/nodeHashjoin.c | |
| parent | a4634b96cc419523b2aa699d0c9129331a6cc079 (diff) | |
| download | postgresql-1ce4a807e25bcd726e34b8d3ba0338e9299f9a87.tar.gz postgresql-1ce4a807e25bcd726e34b8d3ba0338e9299f9a87.zip | |
Fix NULL handling in multi-batch Parallel Hash Left Join.
NULL keys in left joins were skipped when building batch files.
Repair, by making the keep_nulls argument to ExecHashGetHashValue()
depend on whether this is a left outer join, as we do in other
paths.
Bug #15475. Thinko in 1804284042e. Back-patch to 11.
Reported-by: Paul Schaap
Diagnosed-by: Andrew Gierth
Dicussion: https://postgr.es/m/15475-11a7a783fed72a36%40postgresql.org
Diffstat (limited to 'src/backend/executor/nodeHashjoin.c')
| -rw-r--r-- | src/backend/executor/nodeHashjoin.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/executor/nodeHashjoin.c b/src/backend/executor/nodeHashjoin.c index dd94cffbd18..5922e60eed6 100644 --- a/src/backend/executor/nodeHashjoin.c +++ b/src/backend/executor/nodeHashjoin.c @@ -1395,7 +1395,7 @@ ExecParallelHashJoinPartitionOuter(HashJoinState *hjstate) if (ExecHashGetHashValue(hashtable, econtext, hjstate->hj_OuterHashKeys, true, /* outer tuple */ - false, /* outer join, currently unsupported */ + HJ_FILL_OUTER(hjstate), &hashvalue)) { int batchno; |