diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2006-02-28 04:10:28 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2006-02-28 04:10:28 +0000 |
| commit | 2c0ef9777cce8f97dd01073d962e6aa31722b5ad (patch) | |
| tree | bcfa428f69e6013002a79ab29e053bd6c6cbcfa7 /src/backend/executor/nodeHashjoin.c | |
| parent | 7f4f42fa100872507ca10d8e0f7d923acc266ee8 (diff) | |
| download | postgresql-2c0ef9777cce8f97dd01073d962e6aa31722b5ad.tar.gz postgresql-2c0ef9777cce8f97dd01073d962e6aa31722b5ad.zip | |
Extend the ExecInitNode API so that plan nodes receive a set of flag
bits indicating which optional capabilities can actually be exercised
at runtime. This will allow Sort and Material nodes, and perhaps later
other nodes, to avoid unnecessary overhead in common cases.
This commit just adds the infrastructure and arranges to pass the correct
flag values down to plan nodes; none of the actual optimizations are here
yet. I'm committing this separately in case anyone wants to measure the
added overhead. (It should be negligible.)
Simon Riggs and Tom Lane
Diffstat (limited to 'src/backend/executor/nodeHashjoin.c')
| -rw-r--r-- | src/backend/executor/nodeHashjoin.c | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/src/backend/executor/nodeHashjoin.c b/src/backend/executor/nodeHashjoin.c index 7363ab2a2cd..a21184a3a80 100644 --- a/src/backend/executor/nodeHashjoin.c +++ b/src/backend/executor/nodeHashjoin.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/nodeHashjoin.c,v 1.79 2005/11/28 23:46:03 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/nodeHashjoin.c,v 1.80 2006/02/28 04:10:27 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -335,7 +335,7 @@ ExecHashJoin(HashJoinState *node) * ---------------------------------------------------------------- */ HashJoinState * -ExecInitHashJoin(HashJoin *node, EState *estate) +ExecInitHashJoin(HashJoin *node, EState *estate, int eflags) { HashJoinState *hjstate; Plan *outerNode; @@ -345,6 +345,9 @@ ExecInitHashJoin(HashJoin *node, EState *estate) List *hoperators; ListCell *l; + /* check for unsupported flags */ + Assert(!(eflags & (EXEC_FLAG_BACKWARD | EXEC_FLAG_MARK))); + /* * create state structure */ @@ -378,12 +381,16 @@ ExecInitHashJoin(HashJoin *node, EState *estate) /* * initialize child nodes + * + * Note: we could suppress the REWIND flag for the inner input, which + * would amount to betting that the hash will be a single batch. Not + * clear if this would be a win or not. */ outerNode = outerPlan(node); hashNode = (Hash *) innerPlan(node); - outerPlanState(hjstate) = ExecInitNode(outerNode, estate); - innerPlanState(hjstate) = ExecInitNode((Plan *) hashNode, estate); + outerPlanState(hjstate) = ExecInitNode(outerNode, estate, eflags); + innerPlanState(hjstate) = ExecInitNode((Plan *) hashNode, estate, eflags); #define HASHJOIN_NSLOTS 3 |