diff options
| author | Peter Eisentraut <peter_e@gmx.net> | 2009-11-03 09:35:18 +0000 |
|---|---|---|
| committer | Peter Eisentraut <peter_e@gmx.net> | 2009-11-03 09:35:18 +0000 |
| commit | 9e41114676aee46c1aec0212405ee95c131c157e (patch) | |
| tree | 420c15107ed4122e1561d3270d0da1173491bf71 /src/backend/executor/nodeModifyTable.c | |
| parent | 7d535ebe5bf95ca88891c0288fa1c6575498185e (diff) | |
| download | postgresql-9e41114676aee46c1aec0212405ee95c131c157e.tar.gz postgresql-9e41114676aee46c1aec0212405ee95c131c157e.zip | |
Fix obscure segfault condition in PL/Python
In PLy_output(), when the elog() call in the TRY branch throws an exception
(this can happen when a statement timeout kicks in, for example), the
PyErr_SetString() call in the CATCH branch can cause a segfault, because the
Py_XDECREF(so) call before it releases memory that is still used by the sv
variable that PyErr_SetString() uses as argument, because sv points into
memory owned by so.
Backpatched back to 8.0, where this code was introduced.
I also threw in a couple of volatile declarations for variables that are used
before and after the TRY. I don't think they caused the crash that I
observed, but they could become issues.
Diffstat (limited to 'src/backend/executor/nodeModifyTable.c')
0 files changed, 0 insertions, 0 deletions