diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-03-16 16:03:45 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-03-16 16:03:45 -0400 |
commit | bdc7f686d1b8f423cbd60a84cd839eca86475fd6 (patch) | |
tree | af8c09184a6b1398b7b5f171df93bea8e94f033d /src/backend/executor/nodeModifyTable.c | |
parent | b7fbd3f4838631f7279704638caa74b974f22371 (diff) | |
download | postgresql-bdc7f686d1b8f423cbd60a84cd839eca86475fd6.tar.gz postgresql-bdc7f686d1b8f423cbd60a84cd839eca86475fd6.zip |
Fix query-lifespan memory leakage in repeatedly executed hash joins.
ExecHashTableCreate allocated some memory that wasn't freed by
ExecHashTableDestroy, specifically the per-hash-key function information.
That's not a huge amount of data, but if one runs a query that repeats
a hash join enough times, it builds up. Fix by arranging for the data
in question to be kept in the hashtable's hashCxt instead of leaving it
"loose" in the query-lifespan executor context. (This ensures that we'll
also clean up anything that the hash functions allocate in fn_mcxt.)
Per report from Amit Khandekar. It's been like this forever, so back-patch
to all supported branches.
Discussion: https://postgr.es/m/CAJ3gD9cFofAWGvcxLOxDHC=B0hjtW8yGmUsF2hdGh97CM38=7g@mail.gmail.com
Diffstat (limited to 'src/backend/executor/nodeModifyTable.c')
0 files changed, 0 insertions, 0 deletions