diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-03-15 14:00:31 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-03-15 14:00:31 -0400 |
commit | c484134a53d3b1a82449305b0f0710f604f8e8cc (patch) | |
tree | 474e9ccc1de9b060fcf44e9f7a7bc68583d9a13b /src/backend/executor/nodeModifyTable.c | |
parent | a2102e1a92bf0b485487b0582f2efaa9ff025556 (diff) | |
download | postgresql-c484134a53d3b1a82449305b0f0710f604f8e8cc.tar.gz postgresql-c484134a53d3b1a82449305b0f0710f604f8e8cc.zip |
Clean up duplicate role and schema names in regression tests.
Since these names are global, using the same ones in different regression
tests creates a hazard of test failures if any two such scripts run
concurrently. Let's establish a policy of not doing that. In the cases
where a conflict existed, I chose to rename both sides: in principle one
script or the other could've been left in possession of the common name,
but that seems to just invite more trouble of the same sort.
There are a number of places where scripts are using names that seem
unduly generic, but in the absence of actual conflicts I left them alone.
In addition, fix insert.sql's use of "someone_else" as a role name.
That's a flat out violation of longstanding project policy, so back-patch
that change to v10 where the usage appeared. The rest of this is just
future-proofing, as no two of these scripts are actually run concurrently
in the existing parallel_schedule.
Conflicts of schema-qualified names also exist, but will be dealt with
separately.
Discussion: https://postgr.es/m/4627.1521070268@sss.pgh.pa.us
Diffstat (limited to 'src/backend/executor/nodeModifyTable.c')
0 files changed, 0 insertions, 0 deletions