aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor/nodeModifyTable.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2023-12-11 11:51:56 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2023-12-11 11:51:56 -0500
commitebbd499d4b55c6a6223e01e914308f4a3b936a88 (patch)
treec5d380f5f5e2e568a2eed4d167bb8a83aac363d6 /src/backend/executor/nodeModifyTable.c
parent01cc92fa6251c4d1a0ac128806db6f7d8f31ec7f (diff)
downloadpostgresql-ebbd499d4b55c6a6223e01e914308f4a3b936a88.tar.gz
postgresql-ebbd499d4b55c6a6223e01e914308f4a3b936a88.zip
Be more wary about OpenSSL not setting errno on error.
OpenSSL will sometimes return SSL_ERROR_SYSCALL without having set errno; this is apparently a reflection of recv(2)'s habit of not setting errno when reporting EOF. Ensure that we treat such cases the same as read EOF. Previously, we'd frequently report them like "could not accept SSL connection: Success" which is confusing, or worse report them with an unrelated errno left over from some previous syscall. To fix, ensure that errno is zeroed immediately before the call, and report its value only when it's not zero afterwards; otherwise report EOF. For consistency, I've applied the same coding pattern in libpq's pqsecure_raw_read(). Bare recv(2) shouldn't really return -1 without setting errno, but in case it does we might as well cope. Per report from Andres Freund. Back-patch to all supported versions. Discussion: https://postgr.es/m/20231208181451.deqnflwxqoehhxpe@awork3.anarazel.de
Diffstat (limited to 'src/backend/executor/nodeModifyTable.c')
0 files changed, 0 insertions, 0 deletions