aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor/nodeWorktablescan.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2019-02-09 19:45:38 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2019-02-09 19:45:38 -0500
commit2c833217713776d8606fb94e9ab3877d102b86a6 (patch)
treea4ec1f84415e4780f5c85ce15596bce644450617 /src/backend/executor/nodeWorktablescan.c
parent7821a4d60ed677ce19646383a2fc2e9e56319d5f (diff)
downloadpostgresql-2c833217713776d8606fb94e9ab3877d102b86a6.tar.gz
postgresql-2c833217713776d8606fb94e9ab3877d102b86a6.zip
Repair unsafe/unportable snprintf usage in pg_restore.
warn_or_exit_horribly() was blithely passing a potentially-NULL string pointer to a %s format specifier. That works (at least to the extent of not crashing) on some platforms, but not all, and since we switched to our own snprintf.c it doesn't work for us anywhere. Of the three string fields being handled this way here, I think that only "owner" is supposed to be nullable ... but considering that this is error-reporting code, it has very little business assuming anything, so put in defenses for all three. Per a crash observed on buildfarm member crake and then reproduced here. Because of the portability aspect, back-patch to all supported versions.
Diffstat (limited to 'src/backend/executor/nodeWorktablescan.c')
0 files changed, 0 insertions, 0 deletions